jmol haspatch maintainer - please commit #56106

[Brommer, Peter]

Hi,

I recently submitted a patch for jmol (as maintainer). Could somebody with commit privileges please take a look at https://trac.macports.org/ticket/56106 before it becomes outdated again…

Thanks,

Peter

[Mojca Miklavec-2]

Dear Peter,

On 3 April 2018 at 18:23, Peter Brommer wrote:
> Hi,
>
> I recently submitted a patch for jmol (as maintainer). Could somebody with commit privileges please take a look at https://trac.macports.org/ticket/56106 before it becomes outdated again…

Just a suggestion (without taking a look at the ticket yet) ....

While we did not really deprecate submissions via Trac, it turned out
that we have one hyperactive team member who only watches pull
requests on github and always makes sure that no more than 20 are open
at any single moment, while the same cannot be said for Trac with long
backlogs that many people don't notice.

https://trac.macports.org/ticket/56051

So ... I would suggest you to open a PR on GitHub to get this merged
much faster.

Mojca

[Brommer, Peter]

Hi Mojca,

thanks for the suggestion. In my defence, I’m following the (obviously out-of-date) guide at https://trac.macports.org/wiki/howto/Upgrade but I’ll try and use the pull requests for future updates. However, now that I’ve got your attention, could one of commit this patch one final time, even if it comes down the scenic route?

Does trac remain in use for “proper” bug reports?

Peter

On 3 Apr 2018, at 17:28, Mojca Miklavec <[hidden email]> wrote:

Dear Peter,

On 3 April 2018 at 18:23, Peter Brommer wrote:

Hi,

I recently submitted a patch for jmol (as maintainer). Could somebody with commit privileges please take a look at https://trac.macports.org/ticket/56106 before it becomes outdated again…

Just a suggestion (without taking a look at the ticket yet) ....

While we did not really deprecate submissions via Trac, it turned out
that we have one hyperactive team member who only watches pull
requests on github and always makes sure that no more than 20 are open
at any single moment, while the same cannot be said for Trac with long
backlogs that many people don't notice.

https://trac.macports.org/ticket/56051

So ... I would suggest you to open a PR on GitHub to get this merged
much faster.

Mojca

--  
Dr Peter Brommer
Assistant Professor  |  Warwick Centre for Predictive Modelling  |  School of Engineering  |  University of Warwick
[hidden email]  |  www.warwick.ac.uk/pbrommer  |  External: [phone]  |  Internal: 28613  

D2.08  |  School of Engineering  | Library Road | Coventry  |  CV4 7AL  |  United Kingdom

PGP Key: 2048R/B6DEA483 | Fingerprint: 5B6F F30A 9999 79C0 16CD 939E B406 9D2A B6DE A483

[David Strubbe-3]

I committed it.

David

On Tue, Apr 3, 2018 at 12:40 PM, Peter Brommer <[hidden email]> wrote:

Hi Mojca,

thanks for the suggestion. In my defence, I’m following the (obviously out-of-date) guide at https://trac.macports.org/wiki/howto/Upgrade but I’ll try and use the pull requests for future updates. However, now that I’ve got your attention, could one of commit this patch one final time, even if it comes down the scenic route?

Does trac remain in use for “proper” bug reports?

Peter

On 3 Apr 2018, at 17:28, Mojca Miklavec <[hidden email]> wrote:

Dear Peter,

On 3 April 2018 at 18:23, Peter Brommer wrote:

Hi,

I recently submitted a patch for jmol (as maintainer). Could somebody with commit privileges please take a look at https://trac.macports.org/ticket/56106 before it becomes outdated again…

Just a suggestion (without taking a look at the ticket yet) ....

While we did not really deprecate submissions via Trac, it turned out
that we have one hyperactive team member who only watches pull
requests on github and always makes sure that no more than 20 are open
at any single moment, while the same cannot be said for Trac with long
backlogs that many people don't notice.

https://trac.macports.org/ticket/56051

So ... I would suggest you to open a PR on GitHub to get this merged
much faster.

Mojca

--  
Dr Peter Brommer
Assistant Professor  |  Warwick Centre for Predictive Modelling  |  School of Engineering  |  University of Warwick
[hidden email]  |  www.warwick.ac.uk/pbrommer  |  External: [phone]  |  Internal: 28613  

D2.08  |  School of Engineering  | Library Road | Coventry  |  CV4 7AL  |  United Kingdom

PGP Key: 2048R/B6DEA483 | Fingerprint: 5B6F F30A 9999 79C0 16CD 939E B406 9D2A B6DE A483

[Ryan Schmidt-24]

On Apr 3, 2018, at 11:40, Peter Brommer wrote:

> Does trac remain in use for “proper” bug reports?

Yes, Trac is still our bug tracker.

[Perry E. Metzger-2]

On Tue, 3 Apr 2018 17:40:21 +0100 Peter Brommer
<[hidden email]> wrote:
> thanks for the suggestion. In my defence, I’m following the
> (obviously out-of-date) guide at
> https://trac.macports.org/wiki/howto/Upgrade
> <https://trac.macports.org/wiki/howto/Upgrade> but I’ll try and use
> the pull requests for future updates.

I've updated that Wiki page to suggest the use of pull requests over
trac tickets -- someone might want to look at my new language and
see if it can be improved further.

Also, what are the other places where we currently describe the
process to submit new ports or updates to old ones? It would be good
to update those as well.

Perry
--
Perry E. Metzger [hidden email]

[Zero King-2]

On Mon, Apr 09, 2018 at 12:10:47PM -0400, Perry E. Metzger wrote:

>On Tue, 3 Apr 2018 17:40:21 +0100 Peter Brommer
><[hidden email]> wrote:
>> thanks for the suggestion. In my defence, I’m following the
>> (obviously out-of-date) guide at
>> https://trac.macports.org/wiki/howto/Upgrade
>> <https://trac.macports.org/wiki/howto/Upgrade> but I’ll try and use
>> the pull requests for future updates.
>
>I've updated that Wiki page to suggest the use of pull requests over
>trac tickets -- someone might want to look at my new language and
>see if it can be improved further.
>
>Also, what are the other places where we currently describe the
>process to submit new ports or updates to old ones? It would be good
>to update those as well.

In our guide: https://guide.macports.org/#project.contributing / https://github.com/macports/macports-guide.

--
Best regards,
Zero King

[Perry E. Metzger-2]

On Mon, 9 Apr 2018 16:29:56 +0000 Zero King <[hidden email]> wrote:

> On Mon, Apr 09, 2018 at 12:10:47PM -0400, Perry E. Metzger wrote:
> >> I'm following the (obviously out-of-date) guide at
> >> https://trac.macports.org/wiki/howto/Upgrade
> >> but I'll try and use the pull requests for future updates.
> >
> >I've updated that Wiki page to suggest the use of pull requests
> >over trac tickets -- someone might want to look at my new language
> >and see if it can be improved further.
> >
> >Also, what are the other places where we currently describe the
> >process to submit new ports or updates to old ones? It would be
> >good to update those as well.
>
> In our guide: https://guide.macports.org/#project.contributing /
> https://github.com/macports/macports-guide.

I've made some small changes to the Guide to emphasize pull requests
(and to add some mentions of them in places where they weren't
previously mentioned.) I also fixed a last reference to Subversion.

If some else would like to have a look at what I changed, help polish
it, and maybe also help improve the way the Guide explains how to use
Pull Requests, that would be awesome. I'll also be having more of a
look a the guide later.

Perry
--
Perry E. Metzger [hidden email]