Re: [macports-ports] branch master updated: mosh: lint fix

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [macports-ports] branch master updated: mosh: lint fix

Ryan Schmidt-24

> On Mar 9, 2017, at 21:49, Zero King <[hidden email]> wrote:
>
> Zero King (l2dy) pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/3c4734c5cb1f75805de3a85ac78d970585d223a8
>
> The following commit(s) were added to refs/heads/master by this push:
>
>      new 3c4734c  mosh: lint fix
>
> 3c4734c is described below
>
>
> commit 3c4734c5cb1f75805de3a85ac78d970585d223a8
>
> Author: Zero King <[hidden email]>
> AuthorDate: Fri Mar 10 03:49:56 2017 +0000
>
>
>     mosh: lint fix
>
> ---
>  net/mosh/Portfile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
>
> diff --git a/net/mosh/Portfile b/net/mosh/Portfile
> index 2748a78..e5b0424 100644
> --- a/net/mosh/Portfile
> +++ b/net/mosh/Portfile
> @@ -21,7 +21,7 @@ checksums               rmd160  4e06957083f9fcdd4c85b8f3b3b3407f734eed0d \
>                          sha256  7e82b7fbfcc698c70f5843bb960dadb8e7bd7ac1d4d2151c9d979372ea850e85
>  
>  perl5.require_variant   yes
> -perl5.conflict_variants yes
> +perl5.conflict_variants no
>  perl5.branches          5.24
>  perl5.default_branch    5.24
>  perl5.create_variants   ${perl5.branches}

This probably isn't the correct fix. The mosh port does want any perl variants to conflict with one another, so the correct value here was "yes". It just so happens that at this time, there is only one perl version that we're commonly using, so there's only one perl variant.

The real bug is in the perl5 portgroup. It should be fixed so that if there is only one perl variant being created, it does not attempt to add any conflict markers.

Loading...