Re: [macports-ports] branch master updated: minio[-mc]: New ports. s3-compat client and server

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
Report Content as Inappropriate

Re: [macports-ports] branch master updated: minio[-mc]: New ports. s3-compat client and server

Ryan Schmidt-24

> On Mar 3, 2017, at 16:38, Eric A. Borisch <[hidden email]> wrote:
> Eric A. Borisch (eborisch) pushed a commit to branch master
> in repository macports-ports.
> https://github.com/macports/macports-ports/commit/dd54dbf955eb6502444a66a6ee5fe782fcaa2d8a
> The following commit(s) were added to refs/heads/master by this push:
>      new dd54dbf  minio[-mc]: New ports. s3-compat client and server

> +set goproj          github.com/minio/minio

For both minio and minio-mc, you could use the ${github.author} and ${github.project} variables here and elsewhere in the port, to avoid repeating yourself, but it's not a big deal.

> +    xinstall -d ${destroot}${prefix}/share/doc/${name}
> +    foreach f [list README.md LICENSE NOTICE] {
> +        xinstall -m 644 ${worksrcpath}/${f} \
> +            ${destroot}${prefix}/share/doc/${name}/
> +    }

For minio and minio-mc, no need to use a loop here. xinstall can install multiple files in a single command, i.e.:

set docdir ${prefix}/share/doc/${subport}
xinstall -d ${destroot}${docdir}
xinstall -m 644 -W ${worksrcpath} README.md LICENSE NOTICE ${destroot}${docdir}

See https://trac.macports.org/wiki/PortfileRecipes#doc

> +notes " \
> +| If you use 'port load minio':
> +|  * after loading, view ${prefix}/var/log/minio/server.log for server info.
> +|  * Object storage in ${prefix}/var/minio. To relocate:
> +|    * Copy with all (* and .*) contents to desired location.
> +|    * Replace ${prefix}/var/minio with symlink to new storage.
> +|
> +| Or use 'minio server <dir>' to run a server manually / roll your own
> +| startup system. Note './.minio/' will be created by default.
> +|
> +| See also minio-mc port for command-line interaction.
> +"

For minio, you shouldn't use pipes or other ASCII art that would make your port's notes look different from other ports' notes. Just write the paragraphs you want port to print; port will word wrap them to the terminal's width. (Using asterisks as bullets are fine.)