Re: [macports-ports] branch master updated: gcc7 / libgcc: fix build on Intel Tiger

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] branch master updated: gcc7 / libgcc: fix build on Intel Tiger

Ryan Schmidt-24

On Apr 15, 2018, at 22:55, Ken wrote:

> Ken (kencu) pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/084e2e8809afc62472eafc9c098b4bc9249b48b0
>
> The following commit(s) were added to refs/heads/master by this push:
>
>      new 084e2e8  gcc7 / libgcc: fix build on Intel Tiger
>
> 084e2e8 is described below
>
>
> commit 084e2e8809afc62472eafc9c098b4bc9249b48b0
>
> Author: ken-cunningham-webuse
> AuthorDate: Sun Apr 15 20:55:04 2018 -0700
>
>
>     gcc7 / libgcc: fix build on Intel Tiger
>    
>     small patch isolated to Intel Tiger to
>     fix the build of the current libgcc and
>     gcc7 on this system
>
> ---
>  lang/gcc7/Portfile                          |   4 ++
>  lang/gcc7/files/patch-gcc7-tiger-intel.diff | 104 ++++++++++++++++++++++++++++
>  2 files changed, 108 insertions(+)

I'm curious to learn why this fix isn't needed on PowerPC Tiger.


Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] branch master updated: gcc7 / libgcc: fix build on Intel Tiger

Ken Cunningham


> On Apr 16, 2018, at 00:24, Ryan Schmidt <[hidden email]> wrote:
>
>
>> On Apr 15, 2018, at 22:55, Ken wrote:
>>
>> Ken (kencu) pushed a commit to branch master
>> in repository macports-ports.
>>
>>
>> https://github.com/macports/macports-ports/commit/084e2e8809afc62472eafc9c098b4bc9249b48b0
>>
>> The following commit(s) were added to refs/heads/master by this push:
>>
>>     new 084e2e8  gcc7 / libgcc: fix build on Intel Tiger
>>
>> 084e2e8 is described below
>>
>>
>> commit 084e2e8809afc62472eafc9c098b4bc9249b48b0
>>
>> Author: ken-cunningham-webuse
>> AuthorDate: Sun Apr 15 20:55:04 2018 -0700
>>
>>
>>    gcc7 / libgcc: fix build on Intel Tiger
>>
>>    small patch isolated to Intel Tiger to
>>    fix the build of the current libgcc and
>>    gcc7 on this system
>>
>> ---
>> lang/gcc7/Portfile                          |   4 ++
>> lang/gcc7/files/patch-gcc7-tiger-intel.diff | 104 ++++++++++++++++++++++++++++
>> 2 files changed, 108 insertions(+)
>
> I'm curious to learn why this fix isn't needed on PowerPC Tiger.
>
>

me too...I expected Intel Tiger to just build like it does on PPC and was surprised to have to do these fixes to make it work...
Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] branch master updated: gcc7 / libgcc: fix build on Intel Tiger

Ryan Schmidt-24

On Apr 16, 2018, at 03:20, Ken Cunningham wrote:

> On Apr 16, 2018, at 00:24, Ryan Schmidt wrote:
>
>> On Apr 15, 2018, at 22:55, Ken wrote:
>>
>>> Ken (kencu) pushed a commit to branch master
>>> in repository macports-ports.
>>>
>>>
>>> https://github.com/macports/macports-ports/commit/084e2e8809afc62472eafc9c098b4bc9249b48b0
>>>
>>> The following commit(s) were added to refs/heads/master by this push:
>>>
>>>    new 084e2e8  gcc7 / libgcc: fix build on Intel Tiger
>>>
>>> 084e2e8 is described below
>>>
>>>
>>> commit 084e2e8809afc62472eafc9c098b4bc9249b48b0
>>>
>>> Author: ken-cunningham-webuse
>>> AuthorDate: Sun Apr 15 20:55:04 2018 -0700
>>>
>>>
>>>   gcc7 / libgcc: fix build on Intel Tiger
>>>
>>>   small patch isolated to Intel Tiger to
>>>   fix the build of the current libgcc and
>>>   gcc7 on this system
>>>
>>> ---
>>> lang/gcc7/Portfile                          |   4 ++
>>> lang/gcc7/files/patch-gcc7-tiger-intel.diff | 104 ++++++++++++++++++++++++++++
>>> 2 files changed, 108 insertions(+)
>>
>> I'm curious to learn why this fix isn't needed on PowerPC Tiger.
>>
>>
>
> me too...I expected Intel Tiger to just build like it does on PPC and was surprised to have to do these fixes to make it work...


Do these ports build for you on PowerPC Tiger? They didn't for me, last time I checked a month or two ago.


Also, are there MacPorts tickets showing the problem that this patch fixes? And are there upstream bug reports? At the moment, this looks a patch that we'll have to carry forward forever (or until we drop support for these OS versions), without an apparent means of verifying whether the patches continue to be needed in future versions of gcc.

Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] branch master updated: gcc7 / libgcc: fix build on Intel Tiger

Ken Cunningham

On 2018-04-16, at 4:29 PM, Ryan Schmidt wrote:


Do these ports build for you on PowerPC Tiger? They didn't for me, last time I checked a month or two ago.

Yes, both gcc6 / libgcc6 and gcc7 / libgcc7 build fine without these patches on PPC Tiger. I haven't had any troubles with any of these versions. Somehow they don't need these patches, it seems. I don't know why not at this moment.




Also, are there MacPorts tickets showing the problem that this patch fixes?

In fact there is one that I opened that I should close <https://trac.macports.org/ticket/54104>


And are there upstream bug reports?

I will admit to not having looked, although just now google showed me none.

At the moment, this looks a patch that we'll have to carry forward forever (or until we drop support for these OS versions), without an apparent means of verifying whether the patches continue to be needed in future versions of gcc.


Well -- Larry V was helping out with this up in the gcc world when he was active in this. He set the bar at 10.5 Intel, and so gcc defaults to -mmacosx-version-min=10.5 if not otherwise specified.  Which is OK, and certainly goes back a long way.

However, to get gcc6 / gcc7 to build on Tiger Intel is really pretty easy, as you can see.  Just send -mmacosx-version-min=10.4 in a few spots during the build so it builds right and asks for the right link libraries when linking, and replace one function.  

This brings Tiger Intel (who else wants it besides me - not sure?) right up to date with compilers for the next few years with just one patch. And I kinda like the satisfaction of that -- as I know you do.

So would they want that in the main gcc repo? Gee -- what do you think? Rewriting and retesting all Larry V's 10.5 defaulting in darwin.c for a 2004 system ... my bet is no, but I could be wrong...

However, for a simple patch for MacPorts, that stays out of the way of everyone except Tiger Intel, that works now, but that will probably stop working one day (but that could be a long time from now) ...   well, seemed reasonable to me. 

When gcc8 or whatever comes along and Tiger Intel can no longer build it -- c'est la vie. Everything dies.

Best,

Ken