Re: [macports-ports] branch master updated: Update Tesseract to 03.05.01

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] branch master updated: Update Tesseract to 03.05.01

Ryan Schmidt-24

On Mar 13, 2018, at 21:32, Mark Anderson wrote:

> Perry E. Metzger (pmetzger) pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/1b655b8f6dae92268712ca6ff6900ab60008f53e
>
> The following commit(s) were added to refs/heads/master by this push:
>
>      new 1b655b8  Update Tesseract to 03.05.01
>
> 1b655b8 is described below
>
>
> commit 1b655b8f6dae92268712ca6ff6900ab60008f53e
>
> Author: Mark Anderson
> AuthorDate: Tue Mar 13 20:43:00 2018 -0400
>
>
>     Update Tesseract to 03.05.01
>
>    
>
>     * Update Tesseract to 03.05.01
>
>     * Enable building with CMake
>
>    
>
>     Fixes: https://trac.macports.org/ticket/54006
>
>     Closes: https://trac.macports.org/ticket/50128
>
>     Closes: https://trac.macports.org/ticket/50118
>
> ---
>  textproc/tesseract/Portfile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

It fails to build on the buildbot:

CMake Error at /opt/local/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)


On my system, this warning is printed at destroot and should be fixed:

--->  Staging tesseract into destroot
Warning: violation by /opt/local/cmake
Warning: tesseract violates the layout of the ports-filesystems!
Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!

The cmake-1.1 portgroup defines this variable which is presumably where it thinks those files should be installed:

# standard place to install extra CMake modules
set cmake_share_module_dir ${prefix}/share/cmake/Modules

However, it looks like most ports actually install their cmake files into /opt/local/lib/cmake. I don't know if maybe the value in the portgroup is outdated.



> @@ -3,8 +3,9 @@
>  PortSystem          1.0
>  
>  PortGroup           github 1.0
> +PortGroup           cmake 1.1

This affects all subports too, and they don't need cmake. So this portgroup inclusion should be moved to inside the `if {${name} eq ${subport}}` block below.


> @@ -23,8 +24,8 @@ long_description    The Tesseract OCR engine was one of the top  3  engines in \
>  
>  github.master_sites ${github.homepage}/archive/${git.branch}

The next time this port's version is updated, please remove this master_sites override and use the portgroup's defaults. (But don't change it now, because that would change the port from archive to tarball downloads, and the checksums wouldn't match.)


> @@ -32,14 +33,13 @@ if {${name} eq ${subport}} {
>                              port:leptonica \
>                              port:jpeg
>  
> -    configure.env-append    LIBLEPT_HEADERSDIR=${prefix}/include/leptonica
> +    cmake.out_of_source     yes

This is the default for the cmake-1.1 portgroup and doesn't need to be specified.

Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] branch master updated: Update Tesseract to 03.05.01

Mark Anderson-10
I'll take a look at those along with an apparent pkgconfig bug.

—Mark
_______________________
Mark E. Anderson <[hidden email]>

On Tue, Mar 13, 2018 at 11:58 PM, Ryan Schmidt <[hidden email]> wrote:

On Mar 13, 2018, at 21:32, Mark Anderson wrote:

> Perry E. Metzger (pmetzger) pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/1b655b8f6dae92268712ca6ff6900ab60008f53e
>
> The following commit(s) were added to refs/heads/master by this push:
>
>      new 1b655b8  Update Tesseract to 03.05.01
>
> 1b655b8 is described below
>
>
> commit 1b655b8f6dae92268712ca6ff6900ab60008f53e
>
> Author: Mark Anderson
> AuthorDate: Tue Mar 13 20:43:00 2018 -0400
>
>
>     Update Tesseract to 03.05.01
>
>
>
>     * Update Tesseract to 03.05.01
>
>     * Enable building with CMake
>
>
>
>     Fixes: https://trac.macports.org/ticket/54006
>
>     Closes: https://trac.macports.org/ticket/50128
>
>     Closes: https://trac.macports.org/ticket/50118
>
> ---
>  textproc/tesseract/Portfile | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

It fails to build on the buildbot:

CMake Error at /opt/local/share/cmake-3.10/Modules/FindPackageHandleStandardArgs.cmake:137 (message):
  Could NOT find PkgConfig (missing: PKG_CONFIG_EXECUTABLE)


On my system, this warning is printed at destroot and should be fixed:

--->  Staging tesseract into destroot
Warning: violation by /opt/local/cmake
Warning: tesseract violates the layout of the ports-filesystems!
Warning: Please fix or indicate this misbehavior (if it is intended), it will be an error in future releases!

The cmake-1.1 portgroup defines this variable which is presumably where it thinks those files should be installed:

# standard place to install extra CMake modules
set cmake_share_module_dir ${prefix}/share/cmake/Modules

However, it looks like most ports actually install their cmake files into /opt/local/lib/cmake. I don't know if maybe the value in the portgroup is outdated.



> @@ -3,8 +3,9 @@
>  PortSystem          1.0
>
>  PortGroup           github 1.0
> +PortGroup           cmake 1.1

This affects all subports too, and they don't need cmake. So this portgroup inclusion should be moved to inside the `if {${name} eq ${subport}}` block below.


> @@ -23,8 +24,8 @@ long_description    The Tesseract OCR engine was one of the top  3  engines in \
>
>  github.master_sites ${github.homepage}/archive/${git.branch}

The next time this port's version is updated, please remove this master_sites override and use the portgroup's defaults. (But don't change it now, because that would change the port from archive to tarball downloads, and the checksums wouldn't match.)


> @@ -32,14 +33,13 @@ if {${name} eq ${subport}} {
>                              port:leptonica \
>                              port:jpeg
>
> -    configure.env-append    LIBLEPT_HEADERSDIR=${prefix}/include/leptonica
> +    cmake.out_of_source     yes

This is the default for the cmake-1.1 portgroup and doesn't need to be specified.