Re: [macports-ports] 01/02: cad/gtkwave: Using gtk-osx-application-gtk2 (with kludges)

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] 01/02: cad/gtkwave: Using gtk-osx-application-gtk2 (with kludges)

Ryan Schmidt-24

On Mar 10, 2018, at 10:56, Christian Cornelssen wrote:

> Perry E. Metzger (pmetzger) pushed a commit to branch master
> in repository macports-ports.
>
>
> https://github.com/macports/macports-ports/commit/653dffd53c37a8ad0a447086566f6477a34beda0
>
> commit 653dffd53c37a8ad0a447086566f6477a34beda0
>
> Author: Christian Cornelssen
> AuthorDate: Wed Feb 14 01:45:15 2018 +0100
>
>
>     cad/gtkwave: Using gtk-osx-application-gtk2 (with kludges)
>    
>     Also added modeline and normalized whitespace.

Please make whitespace changes (perhaps along with adding the modeline) in a separate commit from functional changes. Otherwise it is very difficult to review the diff and see what the functional changes were.


Reply | Threaded
Open this post in threaded view
|

Re: [macports-ports] 01/02: cad/gtkwave: Using gtk-osx-application-gtk2 (with kludges)

Perry E. Metzger
On Sat, 10 Mar 2018 22:36:14 -0600 Ryan Schmidt
<[hidden email]> wrote:
> Please make whitespace changes (perhaps along with adding the
> modeline) in a separate commit from functional changes. Otherwise
> it is very difficult to review the diff and see what the functional
> changes were.

Normally I'm pretty good about requesting that. Apologies for letting
it slip by this time.

Perry
--
Perry E. Metzger [hidden email]