Re: [macports-base] 01/02: portconfigure: Put a space between -isysroot and the path

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [macports-base] 01/02: portconfigure: Put a space between -isysroot and the path

Ryan Schmidt-24

On Jul 3, 2017, at 23:04, Jeremy Huddleston Sequoia <[hidden email]> wrote:

Jeremy Huddleston Sequoia (jeremyhu) pushed a commit to branch master
in repository macports-base.

https://github.com/macports/macports-base/commit/ef5ecfee6f4324e1b76109e01dd96184221d312f

commit ef5ecfee6f4324e1b76109e01dd96184221d312f
Author: Jeremy Huddleston Sequoia <[hidden email]>
AuthorDate: Mon Jul 3 20:59:33 2017 -0700

    portconfigure: Put a space between -isysroot and the path
    
    This is the preferred/supported CLI (per --help)
    
Can we revert this, please? I deliberately removed the space because using a space is not supported by older toolchains.


    Signed-off-by: Jeremy Huddleston Sequoia <[hidden email]>
---
 src/port1.0/portconfigure.tcl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/port1.0/portconfigure.tcl b/src/port1.0/portconfigure.tcl
index 1aac5a8..fa21ead 100644
--- a/src/port1.0/portconfigure.tcl
+++ b/src/port1.0/portconfigure.tcl
@@ -814,7 +814,7 @@ proc portconfigure::configure_main {args} {
         # add SDK flags if cross-compiling (or universal on ppc tiger)
         if {${configure.sdkroot} ne ""} {
             foreach env_var {CPPFLAGS CFLAGS CXXFLAGS OBJCFLAGS OBJCXXFLAGS} {
-                append_to_environment_value configure $env_var -isysroot${configure.sdkroot}
+                append_to_environment_value configure $env_var -isysroot ${configure.sdkroot}
             }
             append_to_environment_value configure "LDFLAGS" -Wl,-syslibroot,${configure.sdkroot}
         }



Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [macports-base] 01/02: portconfigure: Put a space between -isysroot and the path

Jeremy Huddleston Sequoia
Ugg.

Done.

To github.com:macports/macports-base.git
   677dda56..440fc6c3  master -> master

We may need to hack around this based on compiler version if clang ever becomes stricter here, but hopefully that won't become the case.

> On Jul 4, 2017, at 01:17, Ryan Schmidt <[hidden email]> wrote:
>
>
>> On Jul 3, 2017, at 23:04, Jeremy Huddleston Sequoia <[hidden email]> wrote:
>>
>> Jeremy Huddleston Sequoia (jeremyhu) pushed a commit to branch master
>> in repository macports-base.
>>
>>
>> https://github.com/macports/macports-base/commit/ef5ecfee6f4324e1b76109e01dd96184221d312f
>>
>> commit ef5ecfee6f4324e1b76109e01dd96184221d312f
>>
>> Author: Jeremy Huddleston Sequoia <[hidden email]
>> >
>> AuthorDate: Mon Jul 3 20:59:33 2017 -0700
>>
>>
>>     portconfigure: Put a space between -isysroot and the path
>>
>>    
>>
>>     This is the preferred/supported CLI (per --help)
>>
>>    
>>
> Can we revert this, please? I deliberately removed the space because using a space is not supported by older toolchains.
>
> https://github.com/macports/macports-base/commit/1ab0620c874646646ef4e123a07d38d1452eb6a8
>
>>     Signed-off-by: Jeremy Huddleston Sequoia <[hidden email]
>> >
>>
>> ---
>>  src/port1.0/portconfigure.tcl | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>
>> diff --git a/src/port1.0/portconfigure.tcl b/src/port1.0/portconfigure.tcl
>>
>> index 1aac5a8..fa21ead 100644
>>
>> --- a/src/port1.0/portconfigure.tcl
>>
>> +++ b/src/port1.0/portconfigure.tcl
>>
>> @@ -814,7 +814,7 @@ proc portconfigure::configure_main {args} {
>>
>>          # add SDK flags if cross-compiling (or universal on ppc tiger)
>>          if {${configure.sdkroot} ne ""} {
>>              foreach env_var {CPPFLAGS CFLAGS CXXFLAGS OBJCFLAGS OBJCXXFLAGS} {
>>
>> -                append_to_environment_value configure $env_var -isysroot${configure.sdkroot}
>>
>> +                append_to_environment_value configure $env_var -isysroot ${configure.sdkroot}
>>
>>              }
>>              append_to_environment_value configure "LDFLAGS" -Wl,-syslibroot,${configure.sdkroot}
>>          }
>>
>

Loading...