None Suffix in PAL

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

None Suffix in PAL

Ryosuke Niwa-2
It looks like we've started suffixing platform-independent / generic /
empty implementations inside PAL with *None.cpp as seen in:
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/PAL/pal/text/KillRingNone.cpp
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/PAL/pal/system/SoundNone.cpp

Normally, we either not suffix these files:
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/PlatformEvent.cpp

or suffix with Generic.cpp:
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/platform/ClockGeneric.cpp

I'd suggest not having any suffix when it's empty stub and suffix it
with Generic when it's a generic implementation some platforms in the
accordance with the existing convention.

- R. Niwa
_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
Loading...