Meson 0.56.2 and Python39

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Meson 0.56.2 and Python39

pvr4me
Hi:

It might be that the meson update and/or the switch to python39 has broken builds on older Mac OS versions.  Specifically, I updated dav1d to 0.8.1 and it no longer configures successfully on 10.9 and older versions.  Upstream says that the now-failing configure test (a simple test to see if the compiler can create an executable) has not changed.  

Am I the only one seeing this?

The meson project doesn’t seem to have a change log and I haven’t waded through all of the commits between versions.  Is there a test suite with meson?  Have we checked it?  

Tomorrow, I think I’m going to try to bring up some VM’s and see if meson-log.txt has anything interesting on a failing OS version.

Craig
Reply | Threaded
Open this post in threaded view
|

Re: Meson 0.56.2 and Python39

Ken Cunningham
I will try it.

If I might say — I would expect that anyone submitting a PR has at least built the software on their local system, and used it enough to be sure it at least basically works, if not ran the whole test suite.

SO — meson must have worked properly on at least the system that was used to submit the PR.

I will (and do) thoroughly test the PRs and commits I personally do — which is why the cctools and libmacho and other updates take as long as they do.

I have been reviewing, looking over the changes, checking to build logs and checking the installed files on the PRs before I commit them.

Sometimes, I miss things — out of 150 PRs committed, Ryan and Josh have found corrections (revbumps, etc) in three or four. So I accept that rate.

But I do not expect to find massive broken changes submitted as PRs (we have been seeing some of that at times, hopefully I caught most of it), or otherwise wholly untested PRs that are thrown up without even a passing local build.

That is asking too much of PR reviewers to have absolutely no trust in the PR submitters.

Ken






> On Feb 2, 2021, at 2:32 PM, Craig Treleaven <[hidden email]> wrote:
>
> Hi:
>
> It might be that the meson update and/or the switch to python39 has broken builds on older Mac OS versions.  Specifically, I updated dav1d to 0.8.1 and it no longer configures successfully on 10.9 and older versions.  Upstream says that the now-failing configure test (a simple test to see if the compiler can create an executable) has not changed.  
>
> Am I the only one seeing this?
>
> The meson project doesn’t seem to have a change log and I haven’t waded through all of the commits between versions.  Is there a test suite with meson?  Have we checked it?  
>
> Tomorrow, I think I’m going to try to bring up some VM’s and see if meson-log.txt has anything interesting on a failing OS version.
>
> Craig

Reply | Threaded
Open this post in threaded view
|

Re: Meson 0.56.2 and Python39

pvr4me
Ken:

I wasn’t trying to suggest that anybody failed at anything.  The problem may be specific to dav1d...but if it was more general, I wanted to alert others.  That’s all; I meant no offence to anyone.

And I could see how this might escape notice since it only affects meson on older OS versions.  In the dav1d PR, CI didn’t produce results for the older OS versions.  I thought the CI system was just being grumpy.  I’m very much a neophyte with the PR process.  Github and git still baffle me all too often.

Anyway, I have 'port test meson' running on my 10.10 system even though I don’t expect anything.  I don’t have a working virtualization system at the moment.  Perhaps tomorrow I can get that back up and try the tests on 10.9 and earlier.  And try to build dav1d to get better log info.

Craig

> On Feb 2, 2021, at 6:30 PM, Ken Cunningham <[hidden email]> wrote:
>
> I will try it.
>
> If I might say — I would expect that anyone submitting a PR has at least built the software on their local system, and used it enough to be sure it at least basically works, if not ran the whole test suite.
>
> SO — meson must have worked properly on at least the system that was used to submit the PR.
>
> I will (and do) thoroughly test the PRs and commits I personally do — which is why the cctools and libmacho and other updates take as long as they do.
>
> I have been reviewing, looking over the changes, checking to build logs and checking the installed files on the PRs before I commit them.
>
> Sometimes, I miss things — out of 150 PRs committed, Ryan and Josh have found corrections (revbumps, etc) in three or four. So I accept that rate.
>
> But I do not expect to find massive broken changes submitted as PRs (we have been seeing some of that at times, hopefully I caught most of it), or otherwise wholly untested PRs that are thrown up without even a passing local build.
>
> That is asking too much of PR reviewers to have absolutely no trust in the PR submitters.
>
> Ken
>
>
>
>
>
>
>> On Feb 2, 2021, at 2:32 PM, Craig Treleaven <[hidden email]> wrote:
>>
>> Hi:
>>
>> It might be that the meson update and/or the switch to python39 has broken builds on older Mac OS versions.  Specifically, I updated dav1d to 0.8.1 and it no longer configures successfully on 10.9 and older versions.  Upstream says that the now-failing configure test (a simple test to see if the compiler can create an executable) has not changed.  
>>
>> Am I the only one seeing this?
>>
>> The meson project doesn’t seem to have a change log and I haven’t waded through all of the commits between versions.  Is there a test suite with meson?  Have we checked it?  
>>
>> Tomorrow, I think I’m going to try to bring up some VM’s and see if meson-log.txt has anything interesting on a failing OS version.
>>
>> Craig
>

Reply | Threaded
Open this post in threaded view
|

Re: Meson 0.56.2 and Python39

ryandesign2
Administrator


On Feb 2, 2021, at 18:27, Craig Treleaven wrote:

> In the dav1d PR, CI didn’t produce results for the older OS versions.  I thought the CI system was just being grumpy.

Our CI system uses publicly available build infrastructure from GitHub, which only offers build machines running current versions of macOS, currently 10.14 and later I think.

Designing our own CI build infrastructure and hosting it ourselves is possible, and then we could offer it on as many macOS versions as we like. But the work to do this has not been completed, nor really begun. See other recent mailing list thread.
Reply | Threaded
Open this post in threaded view
|

Re: Meson 0.56.2 and Python39

pvr4me
In reply to this post by pvr4me
> On Feb 2, 2021, at 7:26 PM, Craig Treleaven <[hidden email]> wrote:
>
> Anyway, I have 'port test meson' running on my 10.10 system even though I don’t expect anything.  I don’t have a working virtualization system at the moment.  Perhaps tomorrow I can get that back up and try the tests on 10.9 and earlier.  And try to build dav1d to get better log info.

Actually, the test phase failed on my 10.10 Mac.  I think this is specific test that made it fall over:

g-ir-scanner: link: /usr/bin/clang -o "/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0" -Os "/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0.o" -L. -Wl,-rpath,. "-L/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/samelibname" "-Wl,-rpath,/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/samelibname" "-L/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/" "-Wl,-rpath,/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/" -lsample -lgobject-2.0 -lglib-2.0 -lintl -lgirepository-1.0 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -Wl,-framework -Wl,CoreFoundation -L/opt/local/lib -Wl,-headerpad_max_install_names

dyld: Symbol not found: _meson_sample_get_type

  Referenced from: /opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0
  Expected in: /opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/samelibname/libsample.dylib
 in /opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0
Command '['/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0', '--introspect-dump=/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/functions.txt,/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/dump.xml']' died with <Signals.SIGTRAP: 5>.
ninja: build stopped: subcommand failed.


I also note that there are a lot of messages saying “dirty”, “missing”, “skipping”, and “warning”.  I would hope that if the test phase ran to completion, it would produce a summary of anything important.

Craig

Reply | Threaded
Open this post in threaded view
|

Re: Meson 0.56.2 and Python39

Ken Cunningham
It's a rare port that actually passes all the tests.

Best to compare with a current system and the previous meson before you conclude anything is wrong for certain.

I've been running around enabling test suites on everything I can, including meson <https://github.com/macports/macports-ports/commit/03bd08aa3b13599ca75d899b86ce750aa614ba92#diff-b8e438400c56626bd7fee87efe334c96760964ae9bd38cf171148feb7702613c> , in the hopes of getting people to be more rigorous about such things, but I'm often surprised at the poor performance of things on test suites.

K

On Feb 2, 2021, at 17:32, Craig Treleaven <[hidden email]> wrote:

On Feb 2, 2021, at 7:26 PM, Craig Treleaven <[hidden email]> wrote:

Anyway, I have 'port test meson' running on my 10.10 system even though I don’t expect anything.  I don’t have a working virtualization system at the moment.  Perhaps tomorrow I can get that back up and try the tests on 10.9 and earlier.  And try to build dav1d to get better log info.

Actually, the test phase failed on my 10.10 Mac.  I think this is specific test that made it fall over:

g-ir-scanner: link: /usr/bin/clang -o "/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0" -Os "/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0.o" -L. -Wl,-rpath,. "-L/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/samelibname" "-Wl,-rpath,/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/samelibname" "-L/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/" "-Wl,-rpath,/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/" -lsample -lgobject-2.0 -lglib-2.0 -lintl -lgirepository-1.0 -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lglib-2.0 -lintl -Wl,-framework -Wl,CoreFoundation -L/opt/local/lib -Wl,-headerpad_max_install_names

dyld: Symbol not found: _meson_sample_get_type

 Referenced from: /opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0
 Expected in: /opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/samelibname/libsample.dylib
in /opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0
Command '['/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/Meson-1.0', '--introspect-dump=/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/functions.txt,/opt/local/var/macports/build/_Users_craigtreleaven_mp_macports-ports_devel_meson/meson/work/meson-0.56.2/b b6aebd73f7/tmp-introspectof76ehud/dump.xml']' died with <Signals.SIGTRAP: 5>.
ninja: build stopped: subcommand failed.


I also note that there are a lot of messages saying “dirty”, “missing”, “skipping”, and “warning”.  I would hope that if the test phase ran to completion, it would produce a summary of anything important.

Craig