[MacPorts] #58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of wrong patch for src/subprocess-posix.cc

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of wrong patch for src/subprocess-posix.cc

MacPorts
#58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of
wrong patch for src/subprocess-posix.cc
-----------------------+--------------------
 Reporter:  ballapete  |      Owner:  (none)
     Type:  defect     |     Status:  new
 Priority:  Normal     |  Milestone:
Component:  ports      |    Version:  2.5.4
 Keywords:  tiger      |       Port:  ninja
-----------------------+--------------------
 `Ninja` 1.9.0 has new code in `src/subprocess-posix.cc` so the old patch
 fails. With the new patch it builds and allows to build `meson`.

--
Ticket URL: <https://trac.macports.org/ticket/58099>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of wrong patch for src/subprocess-posix.cc

MacPorts
#58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of
wrong patch for src/subprocess-posix.cc
------------------------+--------------------
  Reporter:  ballapete  |      Owner:  (none)
      Type:  defect     |     Status:  new
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.5.4
Resolution:             |   Keywords:  tiger
      Port:  ninja      |
------------------------+--------------------
Changes (by ballapete):

 * Attachment "patch-tiger-no-posix-spawn-2.diff" added.

 Patchset for Ninja 1.9.0

--
Ticket URL: <https://trac.macports.org/ticket/58099>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of wrong patch for src/subprocess-posix.cc

MacPorts
In reply to this post by MacPorts
#58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of
wrong patch for src/subprocess-posix.cc
------------------------+----------------------------
  Reporter:  ballapete  |      Owner:  ryandesign
      Type:  defect     |     Status:  assigned
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.5.4
Resolution:             |   Keywords:  tiger haspatch
      Port:  ninja      |
------------------------+----------------------------
Changes (by ryandesign):

 * owner:  (none) => ryandesign
 * status:  new => assigned
 * keywords:  tiger => tiger haspatch
 * cc: ryandesign@… (removed)
 * cc: kencu (added)


Comment:

 Ken, any comment? This was your patch.

--
Ticket URL: <https://trac.macports.org/ticket/58099#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of wrong patch for src/subprocess-posix.cc

MacPorts
In reply to this post by MacPorts
#58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of
wrong patch for src/subprocess-posix.cc
------------------------+----------------------------
  Reporter:  ballapete  |      Owner:  ryandesign
      Type:  defect     |     Status:  assigned
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.5.4
Resolution:             |   Keywords:  tiger haspatch
      Port:  ninja      |
------------------------+----------------------------

Comment (by kencu):

 Will check.

--
Ticket URL: <https://trac.macports.org/ticket/58099#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of wrong patch for src/subprocess-posix.cc

MacPorts
In reply to this post by MacPorts
#58099: ninja @1.9.0 does not build on PPC Tiger, Mac OS X 10.4.11, because of
wrong patch for src/subprocess-posix.cc
------------------------+----------------------------
  Reporter:  ballapete  |      Owner:  ryandesign
      Type:  defect     |     Status:  closed
  Priority:  Normal     |  Milestone:
 Component:  ports      |    Version:  2.5.4
Resolution:  fixed      |   Keywords:  tiger haspatch
      Port:  ninja      |
------------------------+----------------------------
Changes (by ken-cunningham-webuse):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"26de0bb48f12cafe3af73aad3d342f51c06c4675/macports-ports"
 26de0bb48f12cafe3af73aad3d342f51c06c4675/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="26de0bb48f12cafe3af73aad3d342f51c06c4675"
 ninja: freshen Tiger patch

 all tests pass
 closes: https://trac.macports.org/ticket/58099

 I'd like to add the posix_spawn functions to legacysupport if possible.
 Otherwise, perhaps we might be able to get upstream to accept
 a version of subprocess_posix.cc that continues to use  fork() if
 posix_spawn is not available.
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/58099#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS