[MacPorts] #57535: opensc @0.19.0_1 build fails with Xcode 10

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #57535: opensc @0.19.0_1 build fails with Xcode 10

MacPorts
#57535: opensc @0.19.0_1 build fails with Xcode 10
---------------------+------------------------
 Reporter:  tgyurci  |      Owner:  lbschenkel
     Type:  defect   |     Status:  assigned
 Priority:  Normal   |  Milestone:
Component:  ports    |    Version:
 Keywords:           |       Port:  opensc
---------------------+------------------------
 Due to changes in pcsclite.h, opensc @0.19.0_1 fails to build with Xcode
 10:

 {{{
 ...
   CC       libopensc_la-card-cardos.lo
 In file included from reader-pcsc.c:41:
 ./internal-winscard.h:146:9: error: 'PCSC_API' macro redefined [-Werror
 ,-Wmacro-redefined]
 #define PCSC_API
         ^
 /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/System/Library/Frameworks/PCSC.framework/Headers/pcsclite.h:51:9:
 note: previous definition is here
 #define PCSC_API extern __attribute__((visibility ("default")))
         ^
 1 error generated.
 ...
 }}}

 Upstream has already fixed this issue:

 https://github.com/OpenSC/OpenSC/issues/1485 [[br]]
 https://github.com/OpenSC/OpenSC/commit/c3bef7d5278c695f3778a629a720bdd8c3c42ce5

--
Ticket URL: <https://trac.macports.org/ticket/57535>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57535: opensc @0.19.0_1 build fails with Xcode 10

MacPorts
#57535: opensc @0.19.0_1 build fails with Xcode 10
----------------------+------------------------
  Reporter:  tgyurci  |      Owner:  lbschenkel
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  opensc   |
----------------------+------------------------

Comment (by lbschenkel):

 Thanks for the report. While trying to fix this problem by incorporating
 that patch, I encountered a different one:
 {{{
 checking winscard.h usability... no
 checking winscard.h presence... no
 checking for winscard.h... no
 configure: error: winscard.h is required for pcsc
 }}}

 This has been reported at https://github.com/OpenSC/OpenSC/issues/1486.
 I'm going to see if I can find a solution.

--
Ticket URL: <https://trac.macports.org/ticket/57535#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57535: opensc @0.19.0_1 build fails with Xcode 10

MacPorts
In reply to this post by MacPorts
#57535: opensc @0.19.0_1 build fails with Xcode 10
----------------------+------------------------
  Reporter:  tgyurci  |      Owner:  lbschenkel
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  opensc   |
----------------------+------------------------

Comment (by bwesterb):

 Issue has been fixed upstream in
 https://github.com/OpenSC/OpenSC/commit/c3bef7d5278c695f3778a629a720bdd8c3c42ce5

 I checked and it fixed it for me.

 This commit hasn't been included in a release yet.  Perhaps add it as a
 patch for now?

--
Ticket URL: <https://trac.macports.org/ticket/57535#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57535: opensc @0.19.0_1 build fails with Xcode 10

MacPorts
In reply to this post by MacPorts
#57535: opensc @0.19.0_1 build fails with Xcode 10
----------------------+------------------------
  Reporter:  tgyurci  |      Owner:  lbschenkel
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  fixed    |   Keywords:
      Port:  opensc   |
----------------------+------------------------
Changes (by lbschenkel):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7fbd9a3b6540b7eca594d7334fd3a75484d8a99c/macports-ports"
 7fbd9a3b6540b7eca594d7334fd3a75484d8a99c/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="7fbd9a3b6540b7eca594d7334fd3a75484d8a99c"
 opensc: fix build issues on Xcode 10

 - add upstream patch to fix errors on Xcode 10 [1]
 - add patch to fix errors on Xcode 10+macOS 13 [2]

 [1] https://github.com/OpenSC/OpenSC/issues/1485
 [2] https://github.com/OpenSC/OpenSC/issues/1486

 Fixes: https://trac.macports.org/ticket/57535
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/57535#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57535: opensc @0.19.0_1 build fails with Xcode 10

MacPorts
In reply to this post by MacPorts
#57535: opensc @0.19.0_1 build fails with Xcode 10
----------------------+------------------------
  Reporter:  tgyurci  |      Owner:  lbschenkel
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  fixed    |   Keywords:
      Port:  opensc   |
----------------------+------------------------

Comment (by lbschenkel):

 Fixed. Sorry for the delay, but I really needed to fix the other issue
 because it made it impossible for me to build the port and I didn't want
 to do it "in the blind".

--
Ticket URL: <https://trac.macports.org/ticket/57535#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS