[MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
------------------------+------------------------
 Reporter:  egorenar    |      Owner:  (none)
     Type:  defect      |     Status:  new
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.5.4
 Keywords:  wireshark2  |       Port:  wireshark2
------------------------+------------------------
 wireshark2 port fails if lua variant is activated.
 with no lua the build succeeds.

--
Ticket URL: <https://trac.macports.org/ticket/57489>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:              |   Keywords:  wireshark2
      Port:  wireshark2  |
-------------------------+------------------------
Changes (by egorenar):

 * Attachment "main.log" added.


--
Ticket URL: <https://trac.macports.org/ticket/57489>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:              |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------
Changes (by Schamschula):

 * owner:  (none) => ghosthound
 * keywords:  wireshark2 =>
 * status:  new => assigned


--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  accepted
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:              |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------
Changes (by ghosthound):

 * status:  assigned => accepted


--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  accepted
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:              |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------

Comment (by ghosthound):

 Works for me, but I'm not on 10.14 and Xcode 10.1.  Presumably there's
 something different with that combo.
 The error appears to be:

   :info:build #error "Unknown number type, check LUA_NUMBER_* in
 luaconf.h"

 Can you have a look at that and see if there's a clue there as to what's
 going on?

--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  accepted
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:              |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------

Comment (by kencu):

 You likely have the newer  `lua @5.3.4_1` installed, and it's trampling
 the `lua52 @5.2.4_1` installation. If you deactivate `lua`, you should be
 able to install `wireshark2 +lua`:
 {{{
 $ port -v installed wireshark2
 The following ports are currently installed:
   wireshark2
 @2.6.4_0+cares+geoip+gnutls+kerberos5+libgcrypt+libsmi+lua+portaudio+qt5+zlib
 (active) platform='darwin 18' archs='x86_64'
 date='2018-11-05T19:02:54-0800'
 }}}
 To fix this, `wireshark2` needs to have the `lua-5.2` include directory
 included AHEAD of the system include directories in it's `CMakeLists.txt`
 file. This is a modest PITA to do, but there are plenty of examples in the
 macports repo of this being done.

 `wireshark2` is not presently compatible with `lua @5.3.4_1`, at least
 with the current versions in MacPorts.

--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:  fixed       |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------
Changes (by ken-cunningham-webuse):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"16c420feca0232775ff57d699d136b5ee4967cb0/macports-ports"
 16c420feca0232775ff57d699d136b5ee4967cb0/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="16c420feca0232775ff57d699d136b5ee4967cb0"
 wireshark2: fix build with +lua when lua5.3 is installed

 brings lua 5.2 include directory ahead of system directories
 so the lua 5.2 lua.h is found as required
 closes: https://trac.macports.org/ticket/57489
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:  fixed       |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------

Comment (by ghosthound):

 While a fix for an issue is always welcome, please do not commit things to
 ports that are not openmaintainer.

--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:  fixed       |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------

Comment (by kencu):

 you're right, I should have added "maintainer timeout" to the commit
 message. Apologies for that.

 <https://github.com/macports/macports-ports/pull/2965>

 <https://guide.macports.org/chunked/project.update-policies.html>

 As you know, it was a trivial fix to a broken variant, otherwise I
 wouldn't have bothered.

--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #57489: wireshark2 @2.6.4+lua: build fails

MacPorts
In reply to this post by MacPorts
#57489: wireshark2 @2.6.4+lua: build fails
-------------------------+------------------------
  Reporter:  egorenar    |      Owner:  ghosthound
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.5.4
Resolution:  fixed       |   Keywords:
      Port:  wireshark2  |
-------------------------+------------------------

Comment (by ghosthound):

 Hmm, never saw the pull notification and can't find it anywhere, not sure
 why as GitHub should be sending them to me.

--
Ticket URL: <https://trac.macports.org/ticket/57489#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS