[MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-------------------------------------+----------------------
 Reporter:  bK4gYuRo                 |      Owner:  (none)
     Type:  defect                   |     Status:  new
 Priority:  Normal                   |  Milestone:
Component:  ports                    |    Version:
 Keywords:  libevent libressl-devel  |       Port:  libevent
-------------------------------------+----------------------
 Errors in the log:
 {{{
 :info:build In file included from sample/le-proxy.c:36:
 :info:build ./openssl-compat.h:6:27: error: static declaration of
 'BIO_meth_new' follows non-static declaration
 :info:build static inline BIO_METHOD *BIO_meth_new(int type, const char
 *name)
 :info:build                           ^
 :info:build /opt/local/include/openssl/bio.h:338:13: note: previous
 declaration is here
 :info:build BIO_METHOD *BIO_meth_new(int type, const char *name);
 :info:build             ^
 :info:build 1 error generated.
 :info:build make[1]: *** [sample/le-proxy.o] Error 1
 :info:build make[1]: *** Waiting for unfinished jobs....
 :info:build In file included from bufferevent_openssl.c:69:
 :info:build ./openssl-compat.h:6:27: error: static declaration of
 'BIO_meth_new' follows non-static declaration
 :info:build static inline BIO_METHOD *BIO_meth_new(int type, const char
 *name)
 :info:build                           ^
 :info:build /opt/local/include/openssl/bio.h:338:13: note: previous
 declaration is here
 :info:build BIO_METHOD *BIO_meth_new(int type, const char *name);
 :info:build             ^
 :info:build 1 error generated.
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/56400>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+-------------------------------------
  Reporter:  bK4gYuRo  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:  libevent libressl-devel
      Port:  libevent  |
-----------------------+-------------------------------------
Changes (by bK4gYuRo):

 * Attachment "main.log" added.


--
Ticket URL: <https://trac.macports.org/ticket/56400>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
In reply to this post by MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+--------------------
  Reporter:  bK4gYuRo  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:  libevent  |
-----------------------+--------------------
Changes (by ryandesign):

 * cc: ryandesign (removed)
 * keywords:  libevent libressl-devel =>


--
Ticket URL: <https://trac.macports.org/ticket/56400#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
In reply to this post by MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+--------------------
  Reporter:  bK4gYuRo  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:  libevent  |
-----------------------+--------------------

Comment (by pmetzger):

 Do libevent's upstream maintainers claim to support libressl? If not, why
 should this be a supported configuration for MacPorts?

--
Ticket URL: <https://trac.macports.org/ticket/56400#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
In reply to this post by MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+--------------------
  Reporter:  bK4gYuRo  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:  libevent  |
-----------------------+--------------------

Comment (by bK4gYuRo):

 What makes you think it is not supported? libevent is a dependency of
 tmux, and tmux (and libevent) builds and works fine on OpenBSD which has
 libressl only. If, following your logic, it's not supported, then it would
 not work on OpenBSD

--
Ticket URL: <https://trac.macports.org/ticket/56400#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
In reply to this post by MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+--------------------
  Reporter:  bK4gYuRo  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:  libevent  |
-----------------------+--------------------

Comment (by raimue):

 libevent @2.1.8 is already the latest stable version, which does not
 support libressl. However, the port applies a [https://github.com/macports
 /macports-ports/commit/43376a714c074aafe9204a8f1257c6da1beda04c patch] to
 make it compatible.

 Looks like this upstream commit needs to be folded into the local patch:
 https://github.com/libevent/libevent/commit/28b8075400c70b2d2da2ce07e590c2ec6d11783d

--
Ticket URL: <https://trac.macports.org/ticket/56400#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
In reply to this post by MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+--------------------
  Reporter:  bK4gYuRo  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:  libevent  |
-----------------------+--------------------

Comment (by pmetzger):

 "If, following your logic, it's not supported, then it would not work on
 OpenBSD"

 The OpenBSD support it in that instance. As raimue has pointed out,
 libevent itself does not support it, though there are patches that will
 make it work.

--
Ticket URL: <https://trac.macports.org/ticket/56400#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
In reply to this post by MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+--------------------
  Reporter:  bK4gYuRo  |      Owner:  (none)
      Type:  defect    |     Status:  new
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:            |   Keywords:
      Port:  libevent  |
-----------------------+--------------------

Comment (by jerryyhom):

 I just encountered this issue.  The upstream patch referenced by Rainer
 has not been folded in yet.  I can submit a PR, but I see two options.

 1. combine upstream patch with existing patch - to replace it
 2. use upstream patch as is - in addition to existing patch

 Is there a preference?

--
Ticket URL: <https://trac.macports.org/ticket/56400#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56400: libevent fails to build with libressl-devel 2.7.2

MacPorts
In reply to this post by MacPorts
#56400: libevent fails to build with libressl-devel 2.7.2
-----------------------+-----------------------
  Reporter:  bK4gYuRo  |      Owner:  jerryyhom
      Type:  defect    |     Status:  closed
  Priority:  Normal    |  Milestone:
 Component:  ports     |    Version:
Resolution:  fixed     |   Keywords:
      Port:  libevent  |
-----------------------+-----------------------
Changes (by jerryyhom):

 * owner:  (none) => jerryyhom
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c7f43dae1e845f2f861cc5300baa1bf0b5ef22e7/macports-ports"
 c7f43dae1e845f2f861cc5300baa1bf0b5ef22e7/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="c7f43dae1e845f2f861cc5300baa1bf0b5ef22e7"
 libevent: fold in upstream patch for libressl 2.7

 close: https://trac.macports.org/ticket/56400
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/56400#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS