[MacPorts] #56246: libzip 1.5.0 still broken

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #56246: libzip 1.5.0 still broken

MacPorts
#56246: libzip 1.5.0 still broken
---------------------------+--------------------
 Reporter:  gaming-hacker  |      Owner:  (none)
     Type:  defect         |     Status:  new
 Priority:  Normal         |  Milestone:
Component:  ports          |    Version:  2.4.2
 Keywords:  source,broken  |       Port:  libzip
---------------------------+--------------------
 All,
 This source seems to be broken, I posted at github and libzip people blame
 zlib headers.  I updated my version of zlib with all the appropriate PRs
 and still can't get this version of libzip to build.



 Errors are :
 {{{
 libzip-1.5.0/regress/ziptool_regress.c:162:6: error: use of undeclared
 identifier 'zip_buffer_fragment_t'
 :info:build             zip_buffer_fragment_t *fragments;
 }}}



 {{{
 ziptool_regress.c:162:29: error: use of undeclared identifier 'fragments';
 did you mean 'nfragments'?
 :info:build             zip_buffer_fragment_t *fragments;
 :info:build                                    ^~~~~~~~~
 :info:build                                    nfragments
 }}}

 plus about 14 more repetitions of this error propagating through the build
 until eventually build stops at reaching error limit.


 {{{
 :info:build 2 warnings and 16 errors generated.
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/56246>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip 1.5.0 still broken

MacPorts
#56246: libzip 1.5.0 still broken
----------------------------+--------------------
  Reporter:  gaming-hacker  |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:  libzip         |
----------------------------+--------------------
Changes (by raimue):

 * keywords:  source,broken =>
 * cc: nomaintainer (removed)


Comment:

 Cannot reproduce. libzip builds on my machine with and also without trace
 mode. Could you attach the main.log?
 macOS 10.12.6 16G1314
 Xcode 9.2 9C40b

--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t' (was: libzip 1.5.0 still broken)

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+--------------------
  Reporter:  gaming-hacker  |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:  libzip         |
----------------------------+--------------------
Changes (by ryandesign):

 * cc: ryandesign (added)


Comment:

 The `-I` flags are in the wrong order, with `-I/opt/local/include` before
 the project's source directories, so upgrades from older versions can
 fail. I've attached my main.log.

--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+--------------------
  Reporter:  gaming-hacker  |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:  libzip         |
----------------------------+--------------------
Changes (by ryandesign):

 * Attachment "main.log" added.


--
Ticket URL: <https://trac.macports.org/ticket/56246>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+--------------------
  Reporter:  gaming-hacker  |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:  libzip         |
----------------------------+--------------------
Changes (by ryandesign):

 * Attachment "main.log" added.


--
Ticket URL: <https://trac.macports.org/ticket/56246>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+--------------------
  Reporter:  gaming-hacker  |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:  libzip         |
----------------------------+--------------------

Comment (by gaming-hacker):

 I backed out the Portfile to previous version of 1.3.2 and the logfile
 that @ryandesign added matches my attempted builds.

 Does this mean a patch to the makefile/configure.in or is there a tcl
 wizard who can work some magic?

--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+--------------------
  Reporter:  gaming-hacker  |      Owner:  (none)
      Type:  defect         |     Status:  new
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:  libzip         |
----------------------------+--------------------

Comment (by kencu):

 Until the CMake issues get sorted out, deactivating the previous libzip
 {{{
 sudo port deactivate libzip
 }}}
 and then installing the new version works.

--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+------------------------
  Reporter:  gaming-hacker  |      Owner:  ryandesign
      Type:  defect         |     Status:  accepted
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:                 |   Keywords:
      Port:  libzip         |
----------------------------+------------------------
Changes (by ryandesign):

 * cc: ryandesign (removed)
 * owner:  (none) => ryandesign
 * status:  new => accepted


--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+------------------------
  Reporter:  gaming-hacker  |      Owner:  ryandesign
      Type:  defect         |     Status:  closed
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:  fixed          |   Keywords:
      Port:  libzip         |
----------------------------+------------------------
Changes (by ryandesign):

 * status:  accepted => closed
 * resolution:   => fixed


Comment:

 In [changeset:"56005de486d09c5472933e7d00b8c220235375c0/macports-ports"
 56005de486d09c5472933e7d00b8c220235375c0/macports-ports]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="56005de486d09c5472933e7d00b8c220235375c0"
 libzip: Fix include path order

 Fixes build failure when upgrading from older version.

 Closes: https://trac.macports.org/ticket/56246
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+------------------------
  Reporter:  gaming-hacker  |      Owner:  ryandesign
      Type:  defect         |     Status:  closed
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:  fixed          |   Keywords:
      Port:  libzip         |
----------------------------+------------------------

Comment (by gaming-hacker):

 The owner of this repo, nih-at, has fixed the cmake command and the next
 version 1.5.1 or 1.5.1a resolved this issue.

 i cloned the repo and cherry picked the PR, built that version and no
 issues as a fresh portfile and as an upgraded portfile.

--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier 'zip_buffer_fragment_t'

MacPorts
In reply to this post by MacPorts
#56246: libzip @1.5.0: Upgrade fails: error: use of undeclared identifier
'zip_buffer_fragment_t'
----------------------------+------------------------
  Reporter:  gaming-hacker  |      Owner:  ryandesign
      Type:  defect         |     Status:  closed
  Priority:  Normal         |  Milestone:
 Component:  ports          |    Version:  2.4.2
Resolution:  fixed          |   Keywords:
      Port:  libzip         |
----------------------------+------------------------

Comment (by ryandesign):

 I know. I used their fix in my commit above.

--
Ticket URL: <https://trac.macports.org/ticket/56246#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS