#56039: Upgrade port:QtCurve, fixing QtCurve-qt5
Reporter: RJVB | Owner:
Type: defect | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: haspatch | Port: QtCurve-qt5
port:QtCurve-qt5 is still shipping an older version which fails to build
against Qt 5.9 and newer. Attached is an update which provides the latest
upstream QtCurve version as well as the current upstream port
implementation from my macstrop repo.
Patchfiles and other resources are in the tarball.
BTW, a monolithic diff wouldn't have helped. The real issue is the lack of
things like the CI system or the ability to do code review here. GitHub is
vastly superior. If there's just one line you should change, I can click
on the line in the diff, attach comments, and even track whether you've
pushed a fix for that line without any effort. It's so much cleaner.
I strongly disagree. The code review mechanisms in GitHub, though
imperfect, are pretty good, and are vastly better than what we have in
Trac, which is no system for such things at all. Trac offers no continuous
integration or test mechanisms either.
Anyway, for good or ill, MacPorts now uses GitHub for much of its work.
Note that I happen to loathe Git (compared to things like Mercurial it's
much less nice) but it's what the tools are now written for and we're kind
of stuck with the world we have rather than the one we wished we lived in.
So, if you want to get your stuff looked at with reasonable speed, please
submit via PRs.
You can disagree all you like with PRs being "about the worst patch review
mechanisms ''I've seen''" if you think that means anything without
actually having looked through my eyes ...
> Note that I happen to loathe Git (compared to things like Mercurial it's
much less nice)
IIRC Mercurial is even slower and/or has an even larger footprint on disk,
or maybe that was bazaar.
Also note that I have often toyed with the idea of creating a true fork of
the ports tree that contains my ports and portgroups. In practice I don't
want to have to maintain one or more copies of that huge ports repo (in
addition to spending my time applying each and every update), so I have
stuck with my macstrop tree with instructions how to "install" it.
> we're kind of stuck with the world we have rather than the one we wished
we lived in.
Indeed, good thing I'm never in a hurry O:-)
(and sadly the co-maintainer I used to have who took care of commits and
PRs is no longer stuck in this world).