[MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
-------------------------+-----------------
 Reporter:  ryandesign   |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  Normal       |  Milestone:
Component:  base         |    Version:
 Keywords:               |       Port:
-------------------------+-----------------
 MacPorts base currently adds a `port:subversion` dependency only on Mac OS
 X Tiger, because Tiger didn't include an `svn` binary. On Leopard and
 later, it adds the dependency `bin:svn:subversion` on the assumption that
 the Apple-provided `svn` binary is sufficient. See
 [4456efc3907271a348313567a82eb5e2c50e8ba4/macports-base].

 Ideally, ports that use `fetch.type svn` should use an https URL to the
 repository. But recently SourceForge has disabled support for older SSL
 protocols, such that the version of `svn` included in OS X El Capitan and
 earlier can no longer connect to it. I suggest we add the
 `port:subversion` dependency, and use the MacPorts version of `svn`, on El
 Capitan and earlier.

 Other alternatives, such as fetching using an http or svn URL, don't work
 well. Using the svn protocol is problematic, because it uses a less common
 port number which some network firewalls block access to. Fetching using
 http is problematic, because http proxies can become confused by the
 additional WebDAV http verbs Subversion uses.

--
Ticket URL: <https://trac.macports.org/ticket/55933>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+-----------------
  Reporter:  ryandesign   |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  base         |    Version:
Resolution:               |   Keywords:
      Port:               |
--------------------------+-----------------

Comment (by mf2k):

 Yes, please just add a dependency on Macports subversion for older OSes.
 Reducing the security for everyone, by using http instead of https, for
 legacy support is not acceptable in my mind.

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+-----------------------------
  Reporter:  ryandesign   |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:  MacPorts Future
 Component:  base         |    Version:
Resolution:               |   Keywords:
      Port:               |
--------------------------+-----------------------------
Changes (by ryandesign):

 * milestone:   => MacPorts Future


--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+-----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts Future
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+-----------------------------
Changes (by ryandesign):

 * owner:   => ryandesign
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8a3b73d263af3da6ad319a84f6bd163c69320cbe/macports-base"
 8a3b73d263af3da6ad319a84f6bd163c69320cbe/macports-base]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-base"
 revision="8a3b73d263af3da6ad319a84f6bd163c69320cbe"
 Use MacPorts svn on El Capitan and earlier

 Closes: https://trac.macports.org/ticket/55933
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+-----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts Future
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+-----------------------------

Comment (by ryandesign):

 In [changeset:"c8fd1a309845eca48b9d265ce87eac56f3ded289/macports-base"
 c8fd1a309845eca48b9d265ce87eac56f3ded289/macports-base]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-base"
 revision="c8fd1a309845eca48b9d265ce87eac56f3ded289"
 Improve wording of comment

 See: https://trac.macports.org/ticket/55933
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+-----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts Future
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+-----------------------------

Comment (by ryandesign):

 In [changeset:"62e07cae09eedfbb9d13a92373e512ed14c04591/macports-base"
 62e07cae09eedfbb9d13a92373e512ed14c04591/macports-base]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-base"
 revision="62e07cae09eedfbb9d13a92373e512ed14c04591"
 portfetch.tcl: Depend on port:subversion on 10.11 and earlier

 See: https://trac.macports.org/ticket/55933
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+-----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts Future
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+-----------------------------

Comment (by jmroot):

 This change broke the svn-and-patchsites test on 10.6 through 10.11.

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------
Changes (by jmroot):

 * milestone:  MacPorts Future => MacPorts 2.5.0


--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by ryandesign):

 Replying to [comment:6 jmroot]:
 > This change broke the svn-and-patchsites test on 10.6 through 10.11.

 I think Clemens fixed that in [ea77eb50b06f009629afb95321f0d5cd932c070b
 /macports-base].

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by jmroot):

 Replying to [comment:1 mf2k]:
 > Yes, please just add a dependency on Macports subversion for older OSes.
 Reducing the security for everyone, by using http instead of https, for
 legacy support is not acceptable in my mind.
 Given that we use `--trust-server-cert` with svn it's not like it's secure
 in the first place…

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:11>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by mf2k):

 Replying to [comment:11 jmroot]:
 > Given that we use `--trust-server-cert` with svn it's not like it's
 secure in the first place…

 That's a different issue. Using https is generally accepted best practice
 for website security and ensuring a valid download.

 I won't ask why we do that but it should probably be addressed in another
 ticket/discussion. If it is needed for a few misconfigured servers, then
 we should include a non-default option to {{{--trust-server-cert}}} for
 those servers only. Something like:

 {{{
 svn.trust_server_cert  yes
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:12>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by mf2k):

 Checking the guide, we already have this which (it says) defaults to no.

 {{{
 fetch.ignore_sslcert    yes
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:13>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by ryandesign):

 Replying to [comment:13 mf2k]:
 > Checking the guide, we already have this which (it says) defaults to no.
 >
 > {{{
 > fetch.ignore_sslcert    yes
 > }}}

 But it is only used when `fetch.type` is `standard`.

 Rainer has already removed `--trust-server-cert` in his vcs-fetch branch;
 see [changeset:704ae4d4a819911df506df6093f94fe4467a049b/macports-base].
 Hopefully that can be merged to master at some point.

 Let's stop the discussion here now, since this ticket is closed.

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:14>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by ryandesign):

 In [changeset:"787d284106c8477d724045c6479f7b07208a845a/macports-base"
 787d284106c8477d724045c6479f7b07208a845a/macports-base]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-base"
 revision="787d284106c8477d724045c6479f7b07208a845a"
 Use MacPorts svn on El Capitan and earlier

 Closes: https://trac.macports.org/ticket/55933
 (cherry picked from commit 8a3b73d263af3da6ad319a84f6bd163c69320cbe)
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:15>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by ryandesign):

 In [changeset:"5233e5d6ddf725232ed0a5380be2dbce0a41861c/macports-base"
 5233e5d6ddf725232ed0a5380be2dbce0a41861c/macports-base]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-base"
 revision="5233e5d6ddf725232ed0a5380be2dbce0a41861c"
 portfetch.tcl: Depend on port:subversion on 10.11 and earlier

 See: https://trac.macports.org/ticket/55933
 (cherry picked from commit 62e07cae09eedfbb9d13a92373e512ed14c04591)
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:17>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.5.0
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------

Comment (by ryandesign):

 In [changeset:"3f1d0f2f76945a0c6c4c45eb2b03e7bc285a84df/macports-base"
 3f1d0f2f76945a0c6c4c45eb2b03e7bc285a84df/macports-base]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-base"
 revision="3f1d0f2f76945a0c6c4c45eb2b03e7bc285a84df"
 Improve wording of comment

 See: https://trac.macports.org/ticket/55933
 (cherry picked from commit c8fd1a309845eca48b9d265ce87eac56f3ded289)
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:16>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier

MacPorts
In reply to this post by MacPorts
#55933: Use MacPorts Subversion when fetch.type svn on OS X El Capitan and earlier
--------------------------+----------------------------
  Reporter:  ryandesign   |      Owner:  ryandesign
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:  MacPorts 2.4.4
 Component:  base         |    Version:
Resolution:  fixed        |   Keywords:
      Port:               |
--------------------------+----------------------------
Changes (by ryandesign):

 * milestone:  MacPorts 2.5.0 => MacPorts 2.4.4


--
Ticket URL: <https://trac.macports.org/ticket/55933#comment:18>
MacPorts <https://www.macports.org/>
Ports system for macOS