[MacPorts] #54600: angband @4.0.5: update to 4.1.0

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
#54600: angband @4.0.5: update to 4.1.0
--------------------+----------------------
 Reporter:  l2dy    |      Owner:  jfcaron3
     Type:  update  |     Status:  new
 Priority:  Normal  |  Milestone:
Component:  ports   |    Version:
 Keywords:          |       Port:  angband
--------------------+----------------------


--
Ticket URL: <https://trac.macports.org/ticket/54600>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+----------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  angband  |
----------------------+----------------------
Changes (by jfcaron3):

 * Attachment "Portfile-angband.diff" added.

 Portfile patch to update angband to 4.1.0.

--
Ticket URL: <https://trac.macports.org/ticket/54600>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
In reply to this post by MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+----------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  angband  |
----------------------+----------------------

Comment (by jfcaron3):

 I made a patch following the instructions on the Guide.  I had to add a
 line about worksrcdir because the latest source archive doesn't untar into
 the expected ${name}-${version} folder, it untars into a folder called
 angband-master.

--
Ticket URL: <https://trac.macports.org/ticket/54600#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
In reply to this post by MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+---------------------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:  haspatch maintainer
      Port:  angband  |
----------------------+---------------------------------
Changes (by raimue):

 * keywords:   => haspatch maintainer


--
Ticket URL: <https://trac.macports.org/ticket/54600#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
In reply to this post by MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+---------------------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:  haspatch maintainer
      Port:  angband  |
----------------------+---------------------------------
Changes (by l2dy):

 * Attachment "0001-angband-update-to-4.1.0-use-the-right-compiler.patch"
 added.


--
Ticket URL: <https://trac.macports.org/ticket/54600>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
In reply to this post by MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+---------------------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:  haspatch maintainer
      Port:  angband  |
----------------------+---------------------------------

Comment (by l2dy):

 I added `CC=${configure.cc}` to use the right compiler, see
 wiki:UsingTheRightCompiler for details.

 @jfcaron3, OK to commit?

--
Ticket URL: <https://trac.macports.org/ticket/54600#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
In reply to this post by MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+---------------------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:  haspatch maintainer
      Port:  angband  |
----------------------+---------------------------------

Comment (by jfcaron3):

 Not sure why CC=${configure.cc} is necessary, even after reading the
 UsingTheRightCompiler page twice.  My interpretation of the page is that
 MacPorts will automatically tell configure to use the XCode compiler,
 UNLESS you set the CC variable...

 "For most ports, the default compiler chosen by MacPorts is the one that
 should be used"

 Anyways, you probably know more about this than I do, so sure go ahead and
 commit.

--
Ticket URL: <https://trac.macports.org/ticket/54600#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
In reply to this post by MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+---------------------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  fixed    |   Keywords:  haspatch maintainer
      Port:  angband  |
----------------------+---------------------------------
Changes (by l2dy):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"313e76ad3b2ef95a0196d4cfbe315ba97249b28d/macports-ports"
 313e76ad3b2ef95a0196d4cfbe315ba97249b28d/macports-ports]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="313e76ad3b2ef95a0196d4cfbe315ba97249b28d"
 angband: update to 4.1.0, use the right compiler

 Fixes: https://trac.macports.org/ticket/54600
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/54600#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54600: angband @4.0.5: update to 4.1.0

MacPorts
In reply to this post by MacPorts
#54600: angband @4.0.5: update to 4.1.0
----------------------+---------------------------------
  Reporter:  l2dy     |      Owner:  jfcaron3
      Type:  update   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  fixed    |   Keywords:  haspatch maintainer
      Port:  angband  |
----------------------+---------------------------------

Comment (by l2dy):

 Replying to [comment:4 jfcaron3]:
 > Not sure why CC=${configure.cc} is necessary, even after reading the
 UsingTheRightCompiler page twice.  My interpretation of the page is that
 MacPorts will automatically tell configure to use the XCode compiler,
 UNLESS you set the CC variable...
 >
 > "For most ports, the default compiler chosen by MacPorts is the one that
 should be used"

 Without `CC=${configure.cc}`, angband will build with the system default
 compiler rather than the compiler chosen by MacPorts.

--
Ticket URL: <https://trac.macports.org/ticket/54600#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS