[MacPorts] #54543: glib2-devel: projects using glib-genmarshal with C++ code break

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[MacPorts] #54543: glib2-devel: projects using glib-genmarshal with C++ code break

MacPorts
#54543: glib2-devel: projects using glib-genmarshal with C++ code break
--------------------+-------------------------
 Reporter:  Ionic   |      Owner:
     Type:  defect  |     Status:  new
 Priority:  Normal  |  Milestone:
Component:  ports   |    Version:
 Keywords:          |       Port:  glib2-devel
--------------------+-------------------------
 `glib2` switched from a C-based `glib-genmarshal` tool to a new
 implementation in Python.

 Since then, projects using `glib-genmarshal` to generate code with
 parameters `--header --body` break if they compile the resulting file as
 C++ code, since the new implementation transparently maps `--header
 --body` to `--body --prototypes`, which does not wrap prototypes in
 `G_{BEGIN,END}_DECLS`. A separate header file is still wrapped correctly,
 leading to linking errors due to name mangling.

 The old tool did wrap the whole implementation file in
 `G_{BEGIN,END}_DECLS`, so that used to work.

 Upstream bug report: https://bugzilla.gnome.org/show_bug.cgi?id=785554

 Will attach a patch backporting that.

--
Ticket URL: <https://trac.macports.org/ticket/54543>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54543: glib2-devel: projects using glib-genmarshal with C++ code break

MacPorts
#54543: glib2-devel: projects using glib-genmarshal with C++ code break
--------------------------+-----------------
  Reporter:  Ionic        |      Owner:
      Type:  defect       |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:
      Port:  glib2-devel  |
--------------------------+-----------------
Changes (by Ionic):

 * Attachment "glib2-devel-genmarshal-review.patch" added.


--
Ticket URL: <https://trac.macports.org/ticket/54543>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54543: glib2-devel: projects using glib-genmarshal with C++ code break

MacPorts
In reply to this post by MacPorts
#54543: glib2-devel: projects using glib-genmarshal with C++ code break
--------------------------+------------------------
  Reporter:  Ionic        |      Owner:  ryandesign
      Type:  defect       |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:
      Port:  glib2-devel  |
--------------------------+------------------------
Changes (by Ionic):

 * owner:   => ryandesign
 * status:  new => assigned


Comment:

 Please review. I'll commit this if you agree.

--
Ticket URL: <https://trac.macports.org/ticket/54543#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54543: glib2-devel: projects using glib-genmarshal with C++ code break

MacPorts
In reply to this post by MacPorts
#54543: glib2-devel: projects using glib-genmarshal with C++ code break
--------------------------+------------------------
  Reporter:  Ionic        |      Owner:  ryandesign
      Type:  defect       |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch
      Port:  glib2-devel  |
--------------------------+------------------------
Changes (by ryandesign):

 * keywords:   => haspatch


Comment:

 I'm not competent to evaluate the patch. If upstream agrees that's the
 correct fix, feel free to commit it.

--
Ticket URL: <https://trac.macports.org/ticket/54543#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54543: glib2-devel: projects using glib-genmarshal with C++ code break

MacPorts
In reply to this post by MacPorts
#54543: glib2-devel: projects using glib-genmarshal with C++ code break
--------------------------+------------------------
  Reporter:  Ionic        |      Owner:  ryandesign
      Type:  defect       |     Status:  closed
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:  fixed        |   Keywords:  haspatch
      Port:  glib2-devel  |
--------------------------+------------------------
Changes (by Ionic):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 Obsoleted by [changeset:"3deafb99bf088e95917297b7076b6b28839f9015
 /macports-ports" 3deafb99bf088e95917297b7076b6b28839f9015/macports-ports]
 (since 2.53.5 includes the patch as per
 https://bugzilla.gnome.org/show_bug.cgi?id=785554.)

 Closing.

--
Ticket URL: <https://trac.macports.org/ticket/54543#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Loading...