[MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

classic Classic list List threaded Threaded
29 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
----------------------+-----------------
 Reporter:  RJVB      |      Owner:
     Type:  update    |     Status:  new
 Priority:  Normal    |  Milestone:
Component:  ports     |    Version:
 Keywords:  haspatch  |       Port:  VLC
----------------------+-----------------
 VLC 2.2.6 is out with a few fixes (one of mine, even) and I stumbled
 across a patch that makes VLC works with FFmpeg >= 3.0 .

 I have been using this for a couple of days now and the resulting binaries
 seem to work just fine, but between my normal day-to-day use and
 exhaustive testing there's a quite a bit of a gap.

 Thus, I'm uploading a patch that disables/hides the `ffmpeg-VLC` subport
 but doesn't remove it completely yet, not until this version has seen more
 real-world usage in the wild.

--
Ticket URL: <https://trac.macports.org/ticket/54480>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+----------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch
      Port:  VLC     |
---------------------+----------------------
Changes (by RJVB):

 * Attachment "patch-ffmpeg3-compat.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/54480>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+----------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch
      Port:  VLC     |
---------------------+----------------------
Changes (by RJVB):

 * Attachment "VLC.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/54480>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------
Changes (by mf2k):

 * keywords:  haspatch => haspatch maintainer


--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by l2dy):

 There're 3 reinplace warnings in patch phase on OS X 10.11.

 {{{
 --->  Patching configure.ac: s:-lstdc++:-lc++:
 Warning: reinplace s:-lstdc++:-lc++: didn't change anything in
 /opt/local/var/macports/build/_Users_*_ports_multimedia_VLC/VLC/work/vlc-2.2.6/configure.ac
 --->  Patching configure.ac: s/Appkit/AppKit/
 Warning: reinplace s/Appkit/AppKit/ didn't change anything in
 /opt/local/var/macports/build/_Users_*_ports_multimedia_VLC/VLC/work/vlc-2.2.6/configure.ac
 --->  Patching decomp.c: /argv/s/environ/*_NSGetEnviron()/
 Warning: reinplace /argv/s/environ/*_NSGetEnviron()/ didn't change
 anything in
 /opt/local/var/macports/build/_Users_*_ports_multimedia_VLC/VLC/work/vlc-2.2.6/modules/stream_filter/decomp.c
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by RJVB):

 Updated, thanks.


 (I actually have a king, officially 8-) )

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------
Changes (by RJVB):

 * Attachment "patch-use-NSGetEnviron.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/54480>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------
Changes (by RJVB):

 * Attachment "VLC-portdir.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/54480>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by l2dy):

 Replying to [comment:3 RJVB]:
 > Updated, thanks.

 Is VLC-portdir.diff ready to be committed?

 > (I actually have a king, officially 8-) )

 What does this mean?

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by l2dy):

 In VLC-portdir.diff, should `depends_lib-append` `port:ffmpeg-
 FFMPEG_VLC_PREFIX` be `port:ffmpeg-VLC`?

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by RJVB):

 Replying to [comment:5 l2dy]:
 > In VLC-portdir.diff, should `depends_lib-append` `port:ffmpeg-
 FFMPEG_VLC_PREFIX` be `port:ffmpeg-VLC`?

 Ah, yes, indeed. Overzealous global-search-and-replace I reckon, something
 I'd evidently have caught the day I tried to go back to depending on the
 ffmpeg-VLC subport. I don't think that'll happen but we'll see what kind
 of feedback we get once the port is out in the wild.

 I wouldn't have submitted this if I thought it wasn't ready to be
 committed. With the caveat emptor outlined above, that support for FFmpeg
 3 comes from a patch I stumbled upon. I'm using the player daily, but
 don't have any really exotic content or recent enough hardware+OS to check
 hardware-accelerated video playback (it works intermittently for me).

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by l2dy):

 Why are the patches in `files/files/`?

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by RJVB):

 Sh**, that's a hasty operator error getting the diff out. I noticed that
 the portdir diff had more patchfiles than I expected but missed the
 subdirectory. Let me find a moment to prepare a proper diff before
 committing, lest I made other stupid mistakes :-/

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------
Changes (by RJVB):

 * Attachment "VLC-portdir.2.diff" added.

 this one looks correct

--
Ticket URL: <https://trac.macports.org/ticket/54480>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by l2dy):

 {{{
 $ port lint VLC
 --->  Verifying Portfile for VLC
 Warning: Line 506 should use the expansion operator instead of the eval
 procedure. Change
 Warning:             eval file delete [glob
 ${destroot}${prefix}/lib/vlc/plugins/*/*.la]
 Warning: to
 Warning:             file delete {*}[glob
 ${destroot}${prefix}/lib/vlc/plugins/*/*.la]
 Error: conflicts references unknown port: libVLC-devel
 --->  1 errors and 1 warnings found.
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------
Changes (by l2dy):

 * Attachment "0001-VLC-upgrade-to-2.2.6-and-FFmpeg-3.patch" added.


--
Ticket URL: <https://trac.macports.org/ticket/54480>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by l2dy):

 I uploaded a patch with lint fixes, can you check if it compiles and works
 fine?

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by RJVB):

 Attaching a diff against the updated Portfile would have been easier...

 Anyway, I really dislike that Tcl expansion operator and `port:libVLC-
 devel` exists on my end (subport of the unmaintained VLC-devel) but yeah,
 your modifications should not introduce any behaviour changes.

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:11>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by l2dy):

 Replying to [comment:11 RJVB]:
 > Attaching a diff against the updated Portfile would have been easier...
 >
 > Anyway, I really dislike that Tcl expansion operator and `port:libVLC-
 devel` exists on my end (subport of the unmaintained VLC-devel) but yeah,
 your modifications should not introduce any behaviour changes.

 Can I commit that as is or should I revert to `eval file delete`?

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:12>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #54480: VLC: upgrade to 2.2.6 and FFmpeg 3

MacPorts
In reply to this post by MacPorts
#54480: VLC: upgrade to 2.2.6 and FFmpeg 3
---------------------+---------------------------------
  Reporter:  RJVB    |      Owner:
      Type:  update  |     Status:  new
  Priority:  Normal  |  Milestone:
 Component:  ports   |    Version:
Resolution:          |   Keywords:  haspatch maintainer
      Port:  VLC     |
---------------------+---------------------------------

Comment (by RJVB):

 No, you can commit as is. In this case there's no real difference.

--
Ticket URL: <https://trac.macports.org/ticket/54480#comment:13>
MacPorts <https://www.macports.org/>
Ports system for macOS
12