[MacPorts] #54478: jsch update to 0.1.54

classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[MacPorts] #54478: jsch update to 0.1.54

MacPorts
#54478: jsch update to 0.1.54
--------------------------+------------------
 Reporter:  chicagotripp  |      Owner:
     Type:  update        |     Status:  new
 Priority:  Normal        |  Milestone:
Component:  ports         |    Version:
 Keywords:  haspatch      |       Port:  jsch
--------------------------+------------------
 I had did a fresh install and reinstalled the port {{{jsch-0.1.53}}} and
 found that it failed on install. The build needed a change as Javac wasn't
 supporting builds prior to {{{target}}} or {{{source}}} {{{1.6}}}. I
 checked for an update and found that the file still failed on the same
 error. I inputed the change to support {{{1.7}}} for both target and
 source in the build.xml file and the port successfully installed. I
 cleaned up the port from the {{{jsch-0.1.53}}} utilizing the awesome
 {{{port lint --nitpick}}} command.

--
Ticket URL: <https://trac.macports.org/ticket/54478>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:
      Type:  update        |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------
Changes (by chicagotripp):

 * Attachment "Portfile.jsch.diff" added.

 Portfile unified diff of update to version jsch-0.1.54

--
Ticket URL: <https://trac.macports.org/ticket/54478>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
In reply to this post by MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:
      Type:  update        |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------
Changes (by chicagotripp):

 * Attachment "patch-build.xml.diff" added.

 Patch file for jsch-0.1.54.

--
Ticket URL: <https://trac.macports.org/ticket/54478>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
In reply to this post by MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:
      Type:  update        |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------

Comment (by mf2k):

 Thanks! It is hard to evaluate your patch because you have mixed
 whitespace changes with functional ones. We prefer that you submit 2
 patches, separating the functional changes from the whitespace ones.

--
Ticket URL: <https://trac.macports.org/ticket/54478#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
In reply to this post by MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:
      Type:  update        |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------

Comment (by chicagotripp):

 Thank you for the feedback. I apologize and I will make sure to do that in
 the future. Do you need me to correct and redo my submissions with your
 suggestions?

 Replying to [comment:1 mf2k]:
 > Thanks! It is hard to evaluate your patch because you have mixed
 whitespace changes with functional ones. We prefer that you submit 2
 patches, separating the functional changes from the whitespace ones.

--
Ticket URL: <https://trac.macports.org/ticket/54478#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
In reply to this post by MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:
      Type:  update        |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------

Comment (by chicagotripp):

 I basically did a version bump to 0.1.54, updated the checksums for the
 new version, made the correction to the build.xml file to allow it to
 complete building, and then included a patch.

--
Ticket URL: <https://trac.macports.org/ticket/54478#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
In reply to this post by MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:
      Type:  update        |     Status:  new
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:                |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------

Comment (by raimue):

 In [changeset:"65d78693582e2520306c6a26e7fa51c38b5c79d7/macports-ports"
 65d78693582e2520306c6a26e7fa51c38b5c79d7/macports-ports]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="65d78693582e2520306c6a26e7fa51c38b5c79d7"
 jsch: Tabs to spaces, whitespace only

 See: https://trac.macports.org/ticket/54478
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/54478#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
In reply to this post by MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:  raimue
      Type:  update        |     Status:  closed
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:  fixed         |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------
Changes (by raimue):

 * owner:   => raimue
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"27e97798ee5be7703fd2882258ee2cd232af1127/macports-ports"
 27e97798ee5be7703fd2882258ee2cd232af1127/macports-ports]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="27e97798ee5be7703fd2882258ee2cd232af1127"
 jsch: Update to version 0.1.54

 Closes: https://trac.macports.org/ticket/54478
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/54478#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #54478: jsch update to 0.1.54

MacPorts
In reply to this post by MacPorts
#54478: jsch update to 0.1.54
---------------------------+----------------------
  Reporter:  chicagotripp  |      Owner:  raimue
      Type:  update        |     Status:  closed
  Priority:  Normal        |  Milestone:
 Component:  ports         |    Version:
Resolution:  fixed         |   Keywords:  haspatch
      Port:  jsch          |
---------------------------+----------------------

Comment (by raimue):

 I separated the whitespace changes and recreated your changes. Thank you
 for your contribution. For future updates as a maintainer, just file Trac
 tickets with a unified diff or open a pull request on GitHub.

--
Ticket URL: <https://trac.macports.org/ticket/54478#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Loading...