[MacPorts] #53995: nmap @7.40 fails to build with libc++

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
#53995: nmap @7.40 fails to build with libc++
---------------------+------------------
 Reporter:  1-61803  |      Owner:
     Type:  defect   |     Status:  new
 Priority:  Normal   |  Milestone:
Component:  ports    |    Version:
 Keywords:           |       Port:  nmap
---------------------+------------------


--
Ticket URL: <https://trac.macports.org/ticket/53995>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+-----------------
  Reporter:  1-61803  |      Owner:
      Type:  defect   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+-----------------
Changes (by 1-61803):

 * Attachment "nmap_failed_main.log" added.


--
Ticket URL: <https://trac.macports.org/ticket/53995>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+-----------------
  Reporter:  1-61803  |      Owner:
      Type:  defect   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+-----------------

Comment (by ryandesign):

 This build system appears to have forgotten that the CXXFLAGS need to be
 passed not just when calling the C++ compiler as a compiler, but also when
 calling it as a linker to link C++ code.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------
Changes (by ryandesign):

 * status:  new => assigned
 * owner:   => danielluke


--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by 1-61803):

 `sudo port install nmap configure.cxxflags="-stdlib=libc++"
 configure.cxx="clang++ -stdlib=libc++"` builds the port.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  wontfix  |   Keywords:
      Port:  nmap     |
----------------------+------------------------
Changes (by danielluke):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 As this only affects older versions of Mac OS X (that I do not have
 available to test on), I'd be happy to include a patch in the port, but
 will otherwise leave this un-fixed.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  wontfix  |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by 1-61803):

 I installed a newer compiler and changed runtime, see
 ticket:53994#comment:3. It built fine.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------
Changes (by ryandesign):

 * cc: ryandesign, rlhamil@… (added)
 * status:  closed => reopened
 * resolution:  wontfix =>


Comment:

 Replying to [comment:4 danielluke]:
 > As this only affects older versions of Mac OS X (that I do not have
 available to test on), I'd be happy to include a patch in the port, but
 will otherwise leave this un-fixed.

 You should have reported the problem to the developers. Richard has now
 done that.

 Let's leave the ticket open until we fix it.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by danielluke):

 > You should have reported the problem to the developers. Richard has now
 done that.

 "Should have" is perhaps a bit strong given the unsupported OS release the
 problem relates to.

 > Let's leave the ticket open until we fix it.

 If you are working this, please take the ticket. You can assign it back to
 me or open a new one for me if you generate a patch.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by iEFdev):

 The upgrade failed, and when I searched, I found this ticket. Logs ended
 with same error.

 Is this still a //“wontfix”//?

 -----

 The command in comment:3 worked fine //(but I used 'upgrade')//. Didn't
 think I would need that, since I have the “LibcxxOnOlderSystems”-fix in my
 macports.conf.


 // # Attaching my log, if that's helpful in any way.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------
Changes (by iEFdev):

 * Attachment "20180324_nmap_main.log" added.


--
Ticket URL: <https://trac.macports.org/ticket/53995>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by ryandesign):

 Replying to [comment:8 iEFdev]:
 > Is this still a //“wontfix”//?

 As far as I am concerned, no; it should still be fixed.

 > The command in comment:3 worked fine //(but I used 'upgrade')//. Didn't
 think I would need that, since I have the “LibcxxOnOlderSystems”-fix in my
 macports.conf.

 You ''shouldn't'' need the workaround in comment:3, but you do, because
 the build system has a bug, and the portfile doesn't work around it. The
 `-stdlib` flag must be passed to every invocation of the C++ compiler, and
 for some files, this build system doesn't.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by iEFdev):

 Replying to [comment:10 ryandesign]:
 > You ''shouldn't'' need the workaround in comment:3, but you do, because
 the build system has a bug, and the portfile doesn't work around it. The
 `-stdlib` flag must be passed to every invocation of the C++ compiler, and
 for some files, this build system doesn't.
 Aah… I see. Thank you for the explaination.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:11>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  reopened
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:           |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by ryandesign):

 Replying to [comment:6 ryandesign]:
 > You should have reported the problem to the developers. Richard has now
 done that.

 I don't remember what I was referring to here. I couldn't find a mailing
 list post or bug report so I filed a new one now:
 https://github.com/nmap/nmap/issues/1161

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:12>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  wontfix  |   Keywords:
      Port:  nmap     |
----------------------+------------------------
Changes (by danielluke):

 * status:  reopened => closed
 * resolution:   => wontfix


Comment:

 As per normal policy, this is a wontfix because I'm not volunteering to
 fix things on very old versions of Mac OS X. If someone supplies a patch
 that can be added to the port (or, better yet, works with upstream to fix
 the issue), then it will get fixed.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:13>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: [MacPorts] #53995: nmap @7.40 fails to build with libc++

MacPorts
In reply to this post by MacPorts
#53995: nmap @7.40 fails to build with libc++
----------------------+------------------------
  Reporter:  1-61803  |      Owner:  danielluke
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:
Resolution:  wontfix  |   Keywords:
      Port:  nmap     |
----------------------+------------------------

Comment (by kencu):

 Although the reason this is happening is because the software build
 scripts are improperly written, the reason newer systems are not seeing it
 is that clang defaults to adding `stdlib=libc++` on a build line if none
 is specified if the OS is 10.9 or greater, and `stdlib=libstdc++` if the
 OS is 10.8 or less.

 The proper fix is to fix the build system. This may never happen, as newer
 systems all work fine, so there is no incentive to fix it.

 I have a proposal in to fix this issue for all older systems forever, on
 all such broken ports, that we are waiting to consider once we wholesale
 switch to libc++ <https://lists.macports.org/pipermail/macports-
 dev/2018-March/037589.html>.

--
Ticket URL: <https://trac.macports.org/ticket/53995#comment:14>
MacPorts <https://www.macports.org/>
Ports system for macOS