Quantcast

[MacPorts] #53988: sqlite3 no longer links to readline

classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
#53988: sqlite3 no longer links to readline
--------------------+---------------------
 Reporter:  posita  |      Owner:
     Type:  defect  |     Status:  new
 Priority:  Normal  |  Milestone:
Component:  ports   |    Version:  2.4.1
 Keywords:          |       Port:  sqlite3
--------------------+---------------------
 At ''some'' point (I'm not sure when), sqlite3 stopped linking to
 readline, which is ''really'' annoying if you have (and value)
 `~/.sqlite_history`.

 {{{
 % port info sqlite3
 sqlite3 @3.18.0 (databases)
 Sub-ports:            sqlite3-tools
 Variants:             universal

 Description:          SQLite3 is an SQL database engine in a C library.
 Programs that link the SQLite3 library can have SQL database access
 without
                       running a separate RDBMS process. The distribution
 comes with a standalone command-line access program (sqlite3) that can be
                       used to administer an SQLite3 database and which
 serves as an example of how to use the SQLite3 library.
 Homepage:             http://www.sqlite.org/

 Library Dependencies: libedit, ncurses
 Platforms:            darwin
 License:              public-domain
 Maintainers:          Email: [hidden email], GitHub: Schamschula
                       Policy: openmaintainer
 % otool -Lv $( which sqlite3 )
 /Users/matt/.site/bin/sqlite3:
         /usr/lib/libSystem.B.dylib (compatibility version 1.0.0, current
 version 1197.1.1)
         time stamp 2 Wed Dec 31 16:00:02 1969
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/53988>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------
  Reporter:  posita   |      Owner:
      Type:  defect   |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------

Comment (by Schamschula):

 Well, there are reasons why we use libedit, rather than readline, see
 #52866

 If you are willing to deal with those issues, we can always add a readline
 variant.

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------
  Reporter:  posita   |      Owner:
      Type:  request  |     Status:  new
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------
Changes (by Schamschula):

 * type:  defect => request


--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  request  |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------
Changes (by Schamschula):

 * owner:   => Schamschula
 * status:  new => assigned


--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  request  |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------

Comment (by posita):

 Does `libedit` not provide command history/editing? Because I have
 `libedit` installed, and have rebuilt `sqlite3`, but I am unable to
 edit/see historical commands.

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  request  |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------
Changes (by Schamschula):

 * cc: mps@… (removed)


--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  request  |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------

Comment (by Schamschula):

 Since when are you having this problem?

 I just saw #31747 (5 years ago) where Ryan Schmidt mentions a licensing
 issue as the reason for changing to libedit.

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  request  |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------

Comment (by posita):

 I know that it was working as desired about a month ago. Maybe `readline`
 is a red herring, but I ''did'' have access to interactive command-line
 editing and command history last month. Here's what I get now:

 {{{
 % sqlite3 --version
 3.18.0 2017-03-28 18:48:43
 424a0d380332858ee55bdebc4af3789f74e70a2b3ba1cf29d84b9b4bcf3e2e37
 [matt:~] % sqlite3
 SQLite version 3.18.0 2017-03-28 18:48:43
 Enter ".help" for usage hints.
 Connected to a transient in-memory database.
 Use ".open FILENAME" to reopen on a persistent database.
 sqlite> ^P
    ...> ;
 Error: unrecognized token: ""
 sqlite> ^D
 }}}

 In other words, `^P` doesn't work anymore to go back through command line
 history.

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  request  |     Status:  assigned
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:           |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------

Comment (by Schamschula):

 This looks to be the issue:

 https://www.mail-archive.com/sqlite-
 [hidden email]/msg102856.html

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  request  |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:  fixed    |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------
Changes (by Schamschula):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"6142fdfc661c9232b58e045a9b10b2ce285ca70e/macports-ports"
 6142fdfc661c9232b58e045a9b10b2ce285ca70e/macports-ports]:
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="6142fdfc661c9232b58e045a9b10b2ce285ca70e"
 sqlite3: fix issue with command history

 Closes: https://trac.macports.org/ticket/53988
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
--------------------------+-------------------------
  Reporter:  posita       |      Owner:  Schamschula
      Type:  enhancement  |     Status:  closed
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:  2.4.1
Resolution:  fixed        |   Keywords:
      Port:  sqlite3      |
--------------------------+-------------------------
Changes (by mf2k):

 * type:  request => enhancement


Comment:

 Note that a "request" ticket type is only for requesting a new port.

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53988: sqlite3 no longer links to readline

MacPorts
In reply to this post by MacPorts
#53988: sqlite3 no longer links to readline
----------------------+-------------------------
  Reporter:  posita   |      Owner:  Schamschula
      Type:  defect   |     Status:  closed
  Priority:  Normal   |  Milestone:
 Component:  ports    |    Version:  2.4.1
Resolution:  fixed    |   Keywords:
      Port:  sqlite3  |
----------------------+-------------------------
Changes (by Schamschula):

 * type:  enhancement => defect


Comment:

 Replying to [comment:10 mf2k]:
 > Note that a "request" ticket type is only for requesting a new port.

 True enough. The first label actually turned out to be correct: the
 problem was indeed related to building sqlite3 against libedit, see above
 links.

--
Ticket URL: <https://trac.macports.org/ticket/53988#comment:11>
MacPorts <https://www.macports.org/>
Ports system for macOS
Loading...