Quantcast

[MacPorts] #53979: buildbot: merge portwatcher jobs

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[MacPorts] #53979: buildbot: merge portwatcher jobs

MacPorts
#53979: buildbot: merge portwatcher jobs
-------------------------+-----------------
 Reporter:  mojca        |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  Low          |  Milestone:
Component:  ports        |    Version:
 Keywords:  buildbot     |       Port:
-------------------------+-----------------
 When there are ten commits to the same port waiting in the job list for
 the port watcher, that port might be built ten times. (OK, in reality it
 would probably be skipped the other nine times.)

 Port watcher already merges some jobs if they are committed simultaneously
 and that seems to work satisfactory. It would probably be OK if we would
 merge all jobs from the waiting list to a single portwatcher item.

 (Feel free to argue and close this ticket if you disagree. I'm not sure if
 the benefit is really substantial in any way.)

--
Ticket URL: <https://trac.macports.org/ticket/53979>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53979: buildbot: merge portwatcher jobs

MacPorts
#53979: buildbot: merge portwatcher jobs
--------------------------+----------------------
  Reporter:  mojca        |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  Low          |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  buildbot
      Port:               |
--------------------------+----------------------

Comment (by ryandesign):

 Is there a specific case where this was actually a problem?

 If you already know in advance that you're going to commit several changes
 to the same port, you should push those changes all at once.

--
Ticket URL: <https://trac.macports.org/ticket/53979#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53979: buildbot: merge portwatcher jobs

MacPorts
In reply to this post by MacPorts
#53979: buildbot: merge portwatcher jobs
--------------------------+----------------------
  Reporter:  mojca        |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  Low          |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  buildbot
      Port:               |
--------------------------+----------------------

Comment (by mojca):

 This has never really been a problem, just a tiny optimisation suggestion.
 I had it on the list in the other "mega" ticket, so I wrote it down as a
 separate issue, but if there's consensus that this makes no sense, we can
 close it and ignore it.

 This might make a difference when there is a long queue, so the timing
 window is longer. Someone spots a problem in a recent commit and fixes it.

 I remember this would usually be the case when a build finished fast on
 one builder (and most likely failed), then I would try to fix the problem,
 commit, the build would still fail, I would commit a fix again etc.
 Meanwhile the commits kept accumulating on 10.5/ppc.

--
Ticket URL: <https://trac.macports.org/ticket/53979#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Loading...