#53445: port:mlt/mlt-qt5 fixes
Reporter: RJVB | Owner:
Type: enhancement | Status: new
Priority: Normal | Milestone:
Component: ports | Version:
Keywords: haspatch | Port: mlt
The attached patch addresses the following issues:
- qt5.depends_component is now available officially so the local copy can
- mlt 6.4.1 doesn't (sufficiently) honour the compiler and build settings
that the Portfile passed in via the environment. This is addressed by
amending the generated config.mak file.
- From 5.7.0 onwards Qt5 requires C++11 which at least on 10.9.5 must be
requested specifically (with mlt's build system). Doing this requires the
previous fix. The C++11 option is added explicitly only when Qt >= 5.7.0
is active but could also be activated unconditionally on platforms that
Mea culpa for the $Id$ line, but I've already said elsewhere that it's
completely ridiculous to fuss about syntax details like `; revision N` vs.
`revision N`. If anything that's up to the port maintainer to decide. This
kind of notation is the best way to avoid forgetting to remove the
revision during an actual version upgrade.
As to the obsolete subport: it was introduced for then-current users of
the port, I presume that those must all have upgraded to `mlt-qt5` by now.
In my opinion the port syntax should follow the usual conventions. No
other port uses such a ` ; revision N` syntax. Of course, from a technical
perspective there are lots of ways to achieve the same and this has the
same results. Portfiles are written in our own domain specific language,
not just anything Tcl allows as valid syntax. Using the same conventions
in every Portfile makes it easier for others to read and understand it and
enable us to maintain such a large number of ports in the MacPorts ports
tree. These rules include indentation with modelines previously agreed
upon and adhering to the common order of options.
The mlt-qt5 port fails to parse after this change when you don't have qt5
% port info mlt-qt5
Error: Unable to open port: Package Qt5Core was not found in the pkg-
config search path.
Perhaps you should add the directory containing `Qt5Core.pc'
to the PKG_CONFIG_PATH environment variable
No package 'Qt5Core' found