[MacPorts] #53445: port:mlt/mlt-qt5 fixes

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
#53445: port:mlt/mlt-qt5 fixes
-------------------------+-----------------
 Reporter:  RJVB         |      Owner:
     Type:  enhancement  |     Status:  new
 Priority:  Normal       |  Milestone:
Component:  ports        |    Version:
 Keywords:  haspatch     |       Port:  mlt
-------------------------+-----------------
 The attached patch addresses the following issues:

 - qt5.depends_component is now available officially so the local copy can
 be removed.
 - mlt 6.4.1 doesn't (sufficiently) honour the compiler and build settings
 that the Portfile passed in via the environment. This is addressed by
 amending the generated config.mak file.
 - From 5.7.0 onwards Qt5 requires C++11 which at least on 10.9.5 must be
 requested specifically (with mlt's build system). Doing this requires the
 previous fix. The C++11 option is added explicitly only when Qt >= 5.7.0
 is active but could also be activated unconditionally on platforms that
 have libc++.

--
Ticket URL: <https://trac.macports.org/ticket/53445>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+----------------------
  Reporter:  RJVB         |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch
      Port:  mlt          |
--------------------------+----------------------
Changes (by RJVB):

 * Attachment "mlt.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/53445>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:
      Type:  enhancement  |     Status:  new
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------
Changes (by mf2k):

 * keywords:  haspatch => haspatch maintainer


--
Ticket URL: <https://trac.macports.org/ticket/53445#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:  ddennedy
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------
Changes (by raimue):

 * owner:   => ddennedy
 * status:  new => assigned


Comment:

 The patch re-introduces the $Id$ line. We are no longer using these.

 {{{#!diff
 -version             6.4.1
 +version             6.4.1 ; revision 1
 }}}

 The `;` should be a newline.

 I don't like the idea of introducing new subports that are immediately
 obsolete. Are you afraid users won't find mlt-qt5?

--
Ticket URL: <https://trac.macports.org/ticket/53445#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:  ddennedy
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------

Comment (by RJVB):

 Mea culpa for the $Id$ line, but I've already said elsewhere that it's
 completely ridiculous to fuss about syntax details like `; revision N` vs.
 `revision N`. If anything that's up to the port maintainer to decide. This
 kind of notation is the best way to avoid forgetting to remove the
 revision during an actual version upgrade.

 As to the obsolete subport: it was introduced for then-current users of
 the port, I presume that those must all have upgraded to `mlt-qt5` by now.

--
Ticket URL: <https://trac.macports.org/ticket/53445#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:  ddennedy
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------

Comment (by raimue):

 In my opinion the port syntax should follow the usual conventions. No
 other port uses such a ` ; revision N` syntax. Of course, from a technical
 perspective there are lots of ways to achieve the same and this has the
 same results. Portfiles are written in our own domain specific language,
 not just anything Tcl allows as valid syntax. Using the same conventions
 in every Portfile makes it easier for others to read and understand it and
 enable us to maintain such a large number of ports in the MacPorts ports
 tree. These rules include indentation with modelines previously agreed
 upon and adhering to the common order of options.

--
Ticket URL: <https://trac.macports.org/ticket/53445#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:  ddennedy
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------
Changes (by RJVB):

 * Attachment "mlt.2.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/53445>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:  ddennedy
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------
Changes (by RJVB):

 * Attachment "patch-commit-a3188e3.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/53445>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:  ddennedy
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------
Changes (by RJVB):

 * Attachment "patch-no-sdl.diff" added.


--
Ticket URL: <https://trac.macports.org/ticket/53445>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [MacPorts] #53445: port:mlt/mlt-qt5 fixes

MacPorts
In reply to this post by MacPorts
#53445: port:mlt/mlt-qt5 fixes
--------------------------+---------------------------------
  Reporter:  RJVB         |      Owner:  ddennedy
      Type:  enhancement  |     Status:  assigned
  Priority:  Normal       |  Milestone:
 Component:  ports        |    Version:
Resolution:               |   Keywords:  haspatch maintainer
      Port:  mlt          |
--------------------------+---------------------------------

Comment (by RJVB):

 I actually had a newer version lying around, introducing 2 patches:

 - a cherry-picked upstream patch fixing a crash-on-exit in certain client
 applications (kdenlive)

 - a variant with patch allowing to build without SDL support, to avoid
 runtime conflicts with SDL2 (or at least the corresponding warnings).

--
Ticket URL: <https://trac.macports.org/ticket/53445#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Loading...