Looking to remove cygwin dependency for javascript tests for Windows ports

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Looking to remove cygwin dependency for javascript tests for Windows ports

Szabo, Stephan (San Francisco)
Hi,

As part of Sony's work on getting the jsconly build for Windows, we're also looking at the possibility of trying to remove/reduce the dependency on Cygwin for the javascript tests from run-javascript-tests since the build itself runs from a normal windows shell. Internally we did a very preliminary POC of a version of run-jsc-stress-tests for windows which built perl scripts for the test scripts rather than shell scripts and were able to get a bunch of the tests running. We attached that to https://bugs.webkit.org/show_bug.cgi?id=174985 . Obviously, that's not a reasonable version for inclusion, but we wanted to discuss whether there was support for removing the dependency before doing too much more down this path.

Our current thinking is that if we go forward with this, we'd probably step it as:
1. Move the test script and test runner code from run-jsc-stress-tests into a ruby file that is included from the main script
2. Make an option to allow using an alternate version of the above
3. Make an alternate version that didn't rely on shell

Thanks,
Stephan
_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Looking to remove cygwin dependency for javascript tests for Windows ports

Alex Christensen-2
I think eventually running all tests on Windows without Cygwin would be a step in the right direction.

> On Aug 2, 2017, at 9:53 AM, Szabo, Stephan (San Francisco) <[hidden email]> wrote:
>
> Hi,
>
> As part of Sony's work on getting the jsconly build for Windows, we're also looking at the possibility of trying to remove/reduce the dependency on Cygwin for the javascript tests from run-javascript-tests since the build itself runs from a normal windows shell. Internally we did a very preliminary POC of a version of run-jsc-stress-tests for windows which built perl scripts for the test scripts rather than shell scripts and were able to get a bunch of the tests running. We attached that to https://bugs.webkit.org/show_bug.cgi?id=174985 . Obviously, that's not a reasonable version for inclusion, but we wanted to discuss whether there was support for removing the dependency before doing too much more down this path.
>
> Our current thinking is that if we go forward with this, we'd probably step it as:
> 1. Move the test script and test runner code from run-jsc-stress-tests into a ruby file that is included from the main script
> 2. Make an option to allow using an alternate version of the above
> 3. Make an alternate version that didn't rely on shell
>
> Thanks,
> Stephan
> _______________________________________________
> webkit-dev mailing list
> [hidden email]
> https://lists.webkit.org/mailman/listinfo/webkit-dev

_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Looking to remove cygwin dependency for javascript tests for Windows ports

Szabo, Stephan (San Francisco)
In reply to this post by Szabo, Stephan (San Francisco)
Hi again,

Also, internally for testing, we were having run-jsc-stress-tests write perl in the test scripts, but is there a preference for which language (perl, python, ruby, ...) to use?

Thanks,
Steph

-----Original Message-----
From: webkit-dev [mailto:[hidden email]] On Behalf Of Szabo, Stephan (San Francisco)
Sent: Wednesday, August 02, 2017 9:53 AM
To: [hidden email]
Subject: [webkit-dev] Looking to remove cygwin dependency for javascript tests for Windows ports

Hi,

As part of Sony's work on getting the jsconly build for Windows, we're also looking at the possibility of trying to remove/reduce the dependency on Cygwin for the javascript tests from run-javascript-tests since the build itself runs from a normal windows shell. Internally we did a very preliminary POC of a version of run-jsc-stress-tests for windows which built perl scripts for the test scripts rather than shell scripts and were able to get a bunch of the tests running. We attached that to https://bugs.webkit.org/show_bug.cgi?id=174985 . Obviously, that's not a reasonable version for inclusion, but we wanted to discuss whether there was support for removing the dependency before doing too much more down this path.

Our current thinking is that if we go forward with this, we'd probably step it as:
1. Move the test script and test runner code from run-jsc-stress-tests into a ruby file that is included from the main script 2. Make an option to allow using an alternate version of the above 3. Make an alternate version that didn't rely on shell

Thanks,
Stephan
_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Looking to remove cygwin dependency for javascript tests for Windows ports

Myles C. Maxfield-2
In reply to this post by Alex Christensen-2
Alex’s claim should be broadened: The right direction is to eventually not use Cygwin for anything at all.

> On Aug 2, 2017, at 8:35 PM, Alex Christensen <[hidden email]> wrote:
>
> I think eventually running all tests on Windows without Cygwin would be a step in the right direction.
>
>> On Aug 2, 2017, at 9:53 AM, Szabo, Stephan (San Francisco) <[hidden email]> wrote:
>>
>> Hi,
>>
>> As part of Sony's work on getting the jsconly build for Windows, we're also looking at the possibility of trying to remove/reduce the dependency on Cygwin for the javascript tests from run-javascript-tests since the build itself runs from a normal windows shell. Internally we did a very preliminary POC of a version of run-jsc-stress-tests for windows which built perl scripts for the test scripts rather than shell scripts and were able to get a bunch of the tests running. We attached that to https://bugs.webkit.org/show_bug.cgi?id=174985 . Obviously, that's not a reasonable version for inclusion, but we wanted to discuss whether there was support for removing the dependency before doing too much more down this path.
>>
>> Our current thinking is that if we go forward with this, we'd probably step it as:
>> 1. Move the test script and test runner code from run-jsc-stress-tests into a ruby file that is included from the main script
>> 2. Make an option to allow using an alternate version of the above
>> 3. Make an alternate version that didn't rely on shell
>>
>> Thanks,
>> Stephan
>> _______________________________________________
>> webkit-dev mailing list
>> [hidden email]
>> https://lists.webkit.org/mailman/listinfo/webkit-dev
>
> _______________________________________________
> webkit-dev mailing list
> [hidden email]
> https://lists.webkit.org/mailman/listinfo/webkit-dev

_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
Loading...