Can we remove ENABLE_STREAMS_API compile flag?

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Can we remove ENABLE_STREAMS_API compile flag?

Tetsuharu OHZEKI
Hi WebKitten,

As I see the following codes and grep,  I seem today's all (?) ports of WebKit
have enabled ENABLE_STREAMS_API flag by default.

- https://trac.webkit.org/browser/trunk/Source/WTF/wtf/PlatformEnable.h?rev=263222#L466
- https://trac.webkit.org/browser/trunk/Source/cmake/OptionsFTW.cmake?rev=263222#L104
- https://trac.webkit.org/browser/trunk/Source/cmake/OptionsWin.cmake?rev=263222#L58
- https://trac.webkit.org/browser/trunk/Source/cmake/OptionsMac.cmake?rev=263222#L87
- https://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=263222#L210
- https://trac.webkit.org/browser/trunk/Source/cmake/tools/vsprops/FeatureDefines.props?rev=263222#L276

If my assumption is right, I'd like to propose to remove this
`ENABLE_STREAMS_API` flag.

What do you think about this?
If I missed some ports, please tell me about them.

--
Tetsuharu OHZEKI
[hidden email]
_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
Reply | Threaded
Open this post in threaded view
|

Re: Can we remove ENABLE_STREAMS_API compile flag?

youenn fablet
This would be a nice simplification.

Le ven. 19 juin 2020 à 01:02, Tetsuharu OHZEKI
<[hidden email]> a écrit :

>
> Hi WebKitten,
>
> As I see the following codes and grep,  I seem today's all (?) ports of WebKit
> have enabled ENABLE_STREAMS_API flag by default.
>
> - https://trac.webkit.org/browser/trunk/Source/WTF/wtf/PlatformEnable.h?rev=263222#L466
> - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsFTW.cmake?rev=263222#L104
> - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsWin.cmake?rev=263222#L58
> - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsMac.cmake?rev=263222#L87
> - https://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=263222#L210
> - https://trac.webkit.org/browser/trunk/Source/cmake/tools/vsprops/FeatureDefines.props?rev=263222#L276
>
> If my assumption is right, I'd like to propose to remove this
> `ENABLE_STREAMS_API` flag.
>
> What do you think about this?
> If I missed some ports, please tell me about them.
>
> --
> Tetsuharu OHZEKI
> [hidden email]
> _______________________________________________
> webkit-dev mailing list
> [hidden email]
> https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev
Reply | Threaded
Open this post in threaded view
|

Re: Can we remove ENABLE_STREAMS_API compile flag?

Tetsuharu OHZEKI
There are no objections after 5 business days.
I'll start to work this in https://bugs.webkit.org/show_bug.cgi?id=213728

--
Tetsuharu OHZEKI
[hidden email]


On Fri, Jun 19, 2020 at 4:21 PM youenn fablet <[hidden email]> wrote:

>
> This would be a nice simplification.
>
> Le ven. 19 juin 2020 à 01:02, Tetsuharu OHZEKI
> <[hidden email]> a écrit :
> >
> > Hi WebKitten,
> >
> > As I see the following codes and grep,  I seem today's all (?) ports of WebKit
> > have enabled ENABLE_STREAMS_API flag by default.
> >
> > - https://trac.webkit.org/browser/trunk/Source/WTF/wtf/PlatformEnable.h?rev=263222#L466
> > - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsFTW.cmake?rev=263222#L104
> > - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsWin.cmake?rev=263222#L58
> > - https://trac.webkit.org/browser/trunk/Source/cmake/OptionsMac.cmake?rev=263222#L87
> > - https://trac.webkit.org/browser/trunk/Source/cmake/WebKitFeatures.cmake?rev=263222#L210
> > - https://trac.webkit.org/browser/trunk/Source/cmake/tools/vsprops/FeatureDefines.props?rev=263222#L276
> >
> > If my assumption is right, I'd like to propose to remove this
> > `ENABLE_STREAMS_API` flag.
> >
> > What do you think about this?
> > If I missed some ports, please tell me about them.
> >
> > --
> > Tetsuharu OHZEKI
> > [hidden email]
> > _______________________________________________
> > webkit-dev mailing list
> > [hidden email]
> > https://lists.webkit.org/mailman/listinfo/webkit-dev
_______________________________________________
webkit-dev mailing list
[hidden email]
https://lists.webkit.org/mailman/listinfo/webkit-dev