#60782: libaacs

classic Classic list List threaded Threaded
11 messages Options
Reply | Threaded
Open this post in threaded view
|

#60782: libaacs

macports-4
#60782: libaacs
-------------------------+---------------------
 Reporter:  dyne2meter   |      Owner:  (none)
     Type:  defect       |     Status:  new
 Priority:  Normal       |  Milestone:
Component:  ports        |    Version:  2.6.2
 Keywords:  libaacs C99  |       Port:  libaacs
-------------------------+---------------------
 {{{
 :info:build src/examples/aacs_info.c:122:33: error: implicit declaration
 of function 'aacs_get_bdj_root_cert_hash' is invalid in C99 [-Werror
 ,-Wimplicit-function-declaration]
 :info:build     const uint8_t *bdj_hash   =
 aacs_get_bdj_root_cert_hash(aacs);
 :info:build                                 ^
 :info:build src/examples/aacs_info.c:122:20: warning: incompatible integer
 to pointer conversion initializing 'const uint8_t *' (aka 'const unsigned
 char *') with an expression of type 'int' [-Wint-conversion]
 :info:build     const uint8_t *bdj_hash   =
 aacs_get_bdj_root_cert_hash(aacs);
 :info:build                    ^
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 :info:build src/examples/aacs_info.c:123:33: error: implicit declaration
 of function 'aacs_get_content_cert_id' is invalid in C99 [-Werror
 ,-Wimplicit-function-declaration]
 :info:build     const uint8_t *cc_id      =
 aacs_get_content_cert_id(aacs);
 :info:build                                 ^
 :info:build src/examples/aacs_info.c:123:20: warning: incompatible integer
 to pointer conversion initializing 'const uint8_t *' (aka 'const unsigned
 char *') with an expression of type 'int' [-Wint-conversion]
 :info:build     const uint8_t *cc_id      =
 aacs_get_content_cert_id(aacs);
 :info:build                    ^            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 :info:build 2 warnings and 2 errors generated.
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60782>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs

macports-4
#60782: libaacs
-------------------------+-------------------------
  Reporter:  dyne2meter  |      Owner:  (none)
      Type:  defect      |     Status:  new
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  libaacs C99
      Port:  libaacs     |
-------------------------+-------------------------
Changes (by dyne2meter):

 * Attachment "main.log.zip" added.

 main.log

--
Ticket URL: <https://trac.macports.org/ticket/60782>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99 (was: libaacs)

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------
Changes (by ryandesign):

 * status:  new => assigned
 * keywords:  libaacs C99 =>
 * owner:  (none) => i0ntempest


Comment:

 It probably shouldn't be using `-Werror`.

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------

Comment (by ryandesign):

 But it built successfully on many macOS versions on our buildbot. The
 10.11 builder was temporarily offline so it hadn't built this yet, but
 it's back online now. We should check if it builds this port without
 error, and if so, we should compare its log with the one attached to this
 ticket to see what's different.

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------

Comment (by dyne2meter):

 It won't differ, at least not by much. This build failure was on 10.11

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------

Comment (by i0ntempest):

 Do you by chance have the previous version of the library active? If yes
 maybe deactivate it and try again, I noticed this when trying to upgrade
 from 0.9 to 0.10

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------

Comment (by jmroot):

 If that works, it would indicate incorrect ordering of include flags.

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------

Comment (by ryandesign):

 Replying to [comment:2 ryandesign]:
 > We should check if it builds this port without error, and if so, we
 should compare its log with the one attached to this ticket to see what's
 different.

 Successful build on buildbot:

 https://build.macports.org/builders/ports-10.11_x86_64-builder/builds/117016

 Looking at the diff between the logs isn't very helpful because the port
 didn't disable silent build rules. I've fixed that now.


 Replying to [comment:4 i0ntempest]:
 > Do you by chance have the previous version of the library active? If yes
 maybe deactivate it and try again, I noticed this when trying to upgrade
 from 0.9 to 0.10

 Yes, I can confirm that I see that problem on my macOS 10.13 system with
 libaacs @0.8.1 installed.

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:  fixed       |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------
Changes (by ryandesign):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"ef39340413dd948928012923c56bb1265477d37d/macports-ports"
 ef39340413dd948928012923c56bb1265477d37d/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="ef39340413dd948928012923c56bb1265477d37d"
 libaacs: Use -isystem instead of -I

 Works around incorrect order of flags and fixes a potential build
 failure when a previous version of the port is installed.

 Closes: https://trac.macports.org/ticket/60782
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:  fixed       |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------

Comment (by jmroot):

 In [changeset:"76973121d7f85a25c850223b7736ced12f5c5aa5/macports-ports"
 76973121d7f85a25c850223b7736ced12f5c5aa5/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="76973121d7f85a25c850223b7736ced12f5c5aa5"
 libaacs: fix incorrect include ordering

 Fixes: https://trac.macports.org/ticket/60782
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60782: libaacs: error: implicit declaration of function is invalid in C99

macports-4
In reply to this post by macports-4
#60782: libaacs: error: implicit declaration of function is invalid in C99
-------------------------+------------------------
  Reporter:  dyne2meter  |      Owner:  i0ntempest
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:  fixed       |   Keywords:
      Port:  libaacs     |
-------------------------+------------------------

Comment (by jmroot):

 https://code.videolan.org/videolan/libaacs/-/merge_requests/9

--
Ticket URL: <https://trac.macports.org/ticket/60782#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS