#60781: llvm-3.4: SyntaxError: invalid syntax

classic Classic list List threaded Threaded
19 messages Options
Reply | Threaded
Open this post in threaded view
|

#60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
------------------------+----------------------
 Reporter:  ryandesign  |      Owner:  jeremyhu
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.6.2
 Keywords:  tiger       |       Port:  llvm-3.4
------------------------+----------------------
 llvm-3.4 fails to build on Tiger because it uses python but the system's
 python 2.3.5 is too old:

 {{{
 :info:build Traceback (most recent call last):
 :info:build   File
 "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_llvm-3.4/llvm-3.4/work/llvm-3.4.2.src/utils
 /llvm-build/llvm-build", line 3, in ?
 :info:build     import llvmbuild
 :info:build   File
 "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_llvm-3.4/llvm-3.4/work/llvm-3.4.2.src/utils
 /llvm-build/llvmbuild/__init__.py", line 1, in ?
 :info:build     from llvmbuild.main import main
 :info:build   File
 "/opt/local/var/macports/build/_opt_local_var_macports_sources_rsync.macports.org_macports_release_tarballs_ports_lang_llvm-3.4/llvm-3.4/work/llvm-3.4.2.src/utils
 /llvm-build/llvmbuild/main.py", line 65
 :info:build     @staticmethod
 :info:build     ^
 :info:build SyntaxError: invalid syntax
 }}}

 Presumably other versions of llvm would be affected too.

 clang-3.4 already uses python27 (or python27-bootstrap); maybe that can be
 extended to apply to the llvm-3.4 part as well.

--
Ticket URL: <https://trac.macports.org/ticket/60781>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------
Changes (by ryandesign):

 * Attachment "main.log.bz2" added.


--
Ticket URL: <https://trac.macports.org/ticket/60781>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 In here <https://github.com/kencu/TigerPorts/tree/master/lang> I have all
 the way up to llvm-7.0/clang-7.0 working on Tiger, with libc++, and --
 although I don't see that particular error, there are -- several dozen -
 Tiger fixes in there.

 If there is appetite, I can start moving these into the MacPorts tree. I
 have not done so to date for reasons of avoiding confusion.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 {{{
 Welcome to Darwin!
 MacMini:~ cunningh$ port -v installed | grep clang
   clang-3.4 @3.4.2_13 (active) platform='darwin 8' archs='i386'
 date='2020-03-10T15:13:46-0700'
   clang-3.7 @3.7.1_6 (active) platform='darwin 8' archs='i386'
 date='2020-03-20T22:12:13-0700'
   clang-3.8 @3.8.1_9+libstdcxx (active) platform='darwin 8' archs='i386'
 date='2020-03-14T23:15:45-0700'
   clang-5.0 @5.0.2_4+emulated_tls+libstdcxx platform='darwin 8'
 archs='i386' date='2020-03-22T20:49:17-0700'
   clang-7.0 @7.1.0_0+emulated_tls+libstdcxx platform='darwin 8'
 archs='i386' date='2020-03-24T15:21:13-0700'
   clang_select @2.2_0 (active) platform='darwin 8' archs='noarch'
 date='2020-03-10T08:07:41-0700'
 MacMini:~ cunningh$ port -v installed | grep llvm
   llvm-3.4 @3.4.2_12 (active) platform='darwin 8' archs='i386'
 date='2020-03-10T13:32:13-0700'
   llvm-3.7 @3.7.1_4 (active) platform='darwin 8' archs='i386'
 date='2020-03-16T22:51:55-0700'
   llvm-3.8 @3.8.1_3 (active) platform='darwin 8' archs='i386'
 date='2020-03-14T19:15:06-0700'
   llvm-5.0 @5.0.2_1 (active) platform='darwin 8' archs='i386'
 date='2020-03-22T11:09:10-0700'
   llvm-7.0 @7.1.0_0+emulated_tls (active) platform='darwin 8' archs='i386'
 date='2020-03-24T11:26:32-0700'
   llvm_select @2_0 (active) platform='darwin 8' archs='noarch'
 date='2020-03-10T08:08:41-0700'
 MacMini:~ cunningh$ port -v installed | grep libcxx
   libcxx @5.0.1_4 platform='darwin 8' archs='i386'
 date='2020-03-16T18:37:39-0700'
   libcxx @5.0.1_4+emulated_tls (active) platform='darwin 8' archs='i386'
 date='2020-03-21T22:35:42-0700'
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 That was one week of coronavirus boredom , BTW...

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by ryandesign):

 Right, thank you for the work figuring things out in your TigerPorts
 repository but I would like any fixes to be brought into the main
 repository. I would like users to be able to install the ports we provide
 without having to go to third-party ports trees.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 So that is permission then to start moving these fixes in?

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  jeremyhu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by ryandesign):

 I haven't looked at what you've done in that repository, but you should
 certainly submit pull requests for changes that are appropriate for the
 main ports tree.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------
Changes (by kencu):

 * owner:  jeremyhu => kencu
 * cc: kencu (removed)
 * cc: jeremyhu (added)


--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:7>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 Oh -- btw -- I just stopped at llvm/clang-7.0 because I had other things
 to do. There was no particular issue I found with the newer ones, I just
 didn't get to them.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:8>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by ryandesign):

 Replying to [ticket:60781 ryandesign]:
 > clang-3.4 already uses python27 (or python27-bootstrap); maybe that can
 be extended to apply to the llvm-3.4 part as well.

 llvm-3.4 does build fine after `sudo port select python python27`,
 suggesting that the above is all that's needed to fix it.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:9>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 thanks. I'll just add this same one from 3.3 <https://github.com/macports
 /macports-ports/commit/5747168bf3803c322e279791ba4833a402a5dd80#diff-
 44f1dc3f531b1f925b6c463781df53a0>.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:10>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by ryandesign):

 Ok, but don't forget to check os.platform before checking os.major. And
 what about the libc++ bootstrap issue?

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:11>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by ryandesign):

 I guess there is no libc++ on 10.4

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:12>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 there will be in a day or two

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:13>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by ryandesign):

 Oh great. Well then don't you just want to take the existing python27
 stuff out of the clang-3.4 subport and into the main part of the port?

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:14>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 not quite that simple with python and llvm-3.4
 <https://github.com/macports/macports-
 ports/blob/8ab1ef8c8ab9892b581c13382407709c33a381ba/lang/llvm-3.4/Portfile#L83>.

 I am tempted to just use python27-bootstrap all the time, but that is not
 super-clean; alternatively more Portfile spaghetti to straighten out what
 we want for every possible permutation....

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:15>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by ryandesign):

 Replying to [comment:15 kencu]:
 > not quite that simple with python and llvm-3.4
 <https://github.com/macports/macports-
 ports/blob/8ab1ef8c8ab9892b581c13382407709c33a381ba/lang/llvm-3.4/Portfile#L83>.

 What are you showing me by pointing me to that code?

 What I am getting at is that the clang-3.4 subport declares a dependency
 on python27. The code you showed me above replaces that with
 python27-bootstrap in the cases where it is necessary. The llvm-3.4
 subport does not declare a dependency on python27 so the code you showed
 me above has no effect in that subport. I am suggesting that the llvm-3.4
 subport should have a python27 dependency (replaced by python27-bootstrap
 by the above code when needed) just like clang-3.4.

 > I am tempted to just use python27-bootstrap all the time, but that is
 not super-clean; alternatively more Portfile spaghetti to straighten out
 what we want for every possible permutation....

 If by all the time you mean on all OS versions, you certainly cannot,
 because it requires libstdc++ which does not exist on Mojave and later. We
 should only use the libstdc++-using bootstrap ports on systems trying to
 bootstrap their way to installing libc++, which is what we already do.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:16>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60781: llvm-3.4: SyntaxError: invalid syntax

macports-4
In reply to this post by macports-4
#60781: llvm-3.4: SyntaxError: invalid syntax
-------------------------+----------------------
  Reporter:  ryandesign  |      Owner:  kencu
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:  tiger
      Port:  llvm-3.4    |
-------------------------+----------------------

Comment (by kencu):

 Replying to [comment:16 ryandesign]:
 > Replying to [comment:15 kencu]:
 > > not quite that simple with python and llvm-3.4
 <https://github.com/macports/macports-
 ports/blob/8ab1ef8c8ab9892b581c13382407709c33a381ba/lang/llvm-3.4/Portfile#L83>.
 >
 > What are you showing me by pointing me to that code?

 Nothing - this is my port - I'm putting my thoughts down about how I am
 going to manage it.


 > > I am tempted to just use python27-bootstrap all the time, but that is
 not super-clean; alternatively more Portfile spaghetti to straighten out
 what we want for every possible permutation....
 >
 > If by all the time you mean on all OS versions, you certainly cannot,
 because it requires libstdc++ which does not exist on Mojave and later. We
 should only use the libstdc++-using bootstrap ports on systems trying to
 bootstrap their way to installing libc++, which is what we already do.

 I guess as the maintainer of this port I would be pretty stupid if that
 all were not totally obvious.

--
Ticket URL: <https://trac.macports.org/ticket/60781#comment:17>
MacPorts <https://www.macports.org/>
Ports system for macOS