#60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

#60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

macports-4
#60762: mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]
------------------------+-------------------------
 Reporter:  ryandesign  |      Owner:  Schamschula
     Type:  defect      |     Status:  assigned
 Priority:  Normal      |  Milestone:
Component:  ports       |    Version:  2.6.2
 Keywords:              |       Port:  mbedtls
------------------------+-------------------------
 https://build.macports.org/builders/ports-10.8_x86_64-builder/builds/20787/steps
 /install-port/logs/stdio

 {{{
 /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_mbedtls/mbedtls/work/mbedtls-2.23.0/library/bignum.c:814:13:
 error: will never be executed [-Werror,-Wunreachable-code]
     return( mpi_uint_bigendian_to_host_c( x ) );
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
 /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_mbedtls/mbedtls/work/mbedtls-2.23.0/library/bignum.c:804:21:
 error: will never be executed [-Werror,-Wunreachable-code]
             return( __builtin_bswap32(x) );
                     ^~~~~~~~~~~~~~~~~
 2 errors generated.
 }}}

 Maybe don't use `-Werror`.

--
Ticket URL: <https://trac.macports.org/ticket/60762>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

macports-4
#60762: mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]
-------------------------+-------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  mbedtls     |
-------------------------+-------------------------

Comment (by ryandesign):

 Manifests a different way on 10.7:

 https://build.macports.org/builders/ports-10.7_x86_64-builder/builds/25697/steps
 /install-port/logs/stdio

 {{{
 /opt/local/var/macports/build/_opt_bblocal_var_buildworker_ports_build_ports_devel_mbedtls/mbedtls/work/mbedtls-2.23.0/include/mbedtls/aes.h:190:5:
 error: duplicated command '\return' [-Werror,-Wdocumentation]
  * \return         #MBEDTLS_ERR_AES_INVALID_KEY_LENGTH on failure.
    ~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60762#comment:1>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

macports-4
In reply to this post by macports-4
#60762: mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]
-------------------------+-------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  mbedtls     |
-------------------------+-------------------------

Comment (by Schamschula):

 In [changeset:"04c9b2d7e79e7bf1a9d54430977dde1fb13aa1ad/macports-ports"
 04c9b2d7e79e7bf1a9d54430977dde1fb13aa1ad/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="04c9b2d7e79e7bf1a9d54430977dde1fb13aa1ad"
 mbedtls: attempt to fix Werror issue

 See: https://trac.macports.org/ticket/60762
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60762#comment:2>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

macports-4
In reply to this post by macports-4
#60762: mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]
-------------------------+-------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  mbedtls     |
-------------------------+-------------------------

Comment (by ryandesign):

 Thanks... Looks like the next problem is:

 {{{
 /usr/bin/ranlib -no_warning_for_no_symbols -c libmbedcrypto.a
 error: /usr/bin/ranlib: unknown option character `n' in:
 -no_warning_for_no_symbols
 }}}

 Could add a dependency on port:cctools for 10.8 and earlier to get a newer
 ranlib.

--
Ticket URL: <https://trac.macports.org/ticket/60762#comment:3>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

macports-4
In reply to this post by macports-4
#60762: mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]
-------------------------+-------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  mbedtls     |
-------------------------+-------------------------

Comment (by Schamschula):

 In [changeset:"3d59f47eed7a4a3794ff447d62ab9cb839b34039/macports-ports"
 3d59f47eed7a4a3794ff447d62ab9cb839b34039/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="3d59f47eed7a4a3794ff447d62ab9cb839b34039"
 mbedtls: continue trying to fix build on older macOS versions

 See: https://trac.macports.org/ticket/60762
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60762#comment:4>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

macports-4
In reply to this post by macports-4
#60762: mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]
-------------------------+-------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  assigned
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:              |   Keywords:
      Port:  mbedtls     |
-------------------------+-------------------------

Comment (by Schamschula):

 Well, using cctools didn't help.

--
Ticket URL: <https://trac.macports.org/ticket/60762#comment:5>
MacPorts <https://www.macports.org/>
Ports system for macOS
Reply | Threaded
Open this post in threaded view
|

Re: #60762: mbedtls @2.23.0: error: will never be executed [-Werror, -Wunreachable-code]

macports-4
In reply to this post by macports-4
#60762: mbedtls @2.23.0: error: will never be executed [-Werror,-Wunreachable-code]
-------------------------+-------------------------
  Reporter:  ryandesign  |      Owner:  Schamschula
      Type:  defect      |     Status:  closed
  Priority:  Normal      |  Milestone:
 Component:  ports       |    Version:  2.6.2
Resolution:  fixed       |   Keywords:
      Port:  mbedtls     |
-------------------------+-------------------------
Changes (by ryandesign):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"9c3080dc61cd631612dbd0c263e48aaf7b29e92a/macports-ports"
 9c3080dc61cd631612dbd0c263e48aaf7b29e92a/macports-ports] (master):
 {{{
 #!ConfigurableCommitTicketReference repository="macports-ports"
 revision="9c3080dc61cd631612dbd0c263e48aaf7b29e92a"
 mbedtls: Use MacPorts ranlib on 10.8 and earlier

 Closes: https://trac.macports.org/ticket/60762
 }}}

--
Ticket URL: <https://trac.macports.org/ticket/60762#comment:6>
MacPorts <https://www.macports.org/>
Ports system for macOS